Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Matrix tests] Missing general double type case in initialization and ref compute #12800

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[SYCL][Matrix tests] Missing general double type case in initialization and ref compute #12800

merged 1 commit into from
Feb 23, 2024

Conversation

dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Feb 22, 2024

No description provided.

@dkhaldi dkhaldi requested a review from a team as a code owner February 22, 2024 16:45
YuriPlyakhin
YuriPlyakhin reviewed Feb 22, 2024
View reviewed changes
sycl/test-e2e/Matrix/common.hpp
Comment on lines +68 to +69
(std::is_same_v<Ta, double> &&
std::is_same_v<Tc, double>))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
(std::is_same_v<Ta, double> &&
std::is_same_v<Tc, double>))
std::is_same_v<Ta, double> &&
std::is_same_v<Tc, double>)

YuriPlyakhin
YuriPlyakhin reviewed Feb 22, 2024
View reviewed changes
sycl/test-e2e/Matrix/common.hpp
@@ -127,7 +129,8 @@ void matrix_rand(unsigned int rows, unsigned int cols, T *src, T val) {

for (unsigned int i = 0; i < rows; i++) {
for (unsigned int j = 0; j < cols; j++) {
if constexpr (std::is_same_v<T, bfloat16> || std::is_same_v<T, float>) {
if constexpr (std::is_same_v<T, bfloat16> || std::is_same_v<T, float> ||
std::is_same_v<T, double>) {
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we want to use std::uniform_real_distribution<double> for double type?

YuriPlyakhin
YuriPlyakhin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple comments - feel free to address or not.

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Feb 22, 2024

@intel/llvm-gatekeepers, can you please help merge?
The failures are independent of this change and have been already reported in #12797 and #12798
Windows Gen12:
Failed Tests (8):
SYCL :: Assert/assert_in_kernels_win.cpp
SYCL :: Assert/assert_in_multiple_tus_one_ndebug_win.cpp
SYCL :: Assert/assert_in_multiple_tus_win.cpp
SYCL :: Assert/assert_in_one_kernel_win.cpp
SYCL :: Assert/assert_in_simultaneous_kernels_win.cpp
SYCL :: Assert/assert_in_simultaneously_multiple_tus.cpp
SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp
SYCL :: Plugin/sycl-ls-unified-runtime.cpp

@steffenlarsen steffenlarsen merged commit 652d3ea into intel:sycl Feb 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkhaldi @YuriPlyakhin @steffenlarsen