-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Bindless][Exp] Fix get_mip_level_mem_handle declaration. #12822
Conversation
e16dd83
to
0cdb385
Compare
A declaration of get_mip_level_mem_handle incorrectly took sycl::device as a parameter, which should have been a sycl::queue. This is now fixed.
0cdb385
to
ed3fd71
Compare
Is this not an ABI break? I would've expected CI to catch that and fail.. I'd think that the right way to do this would be to deprecate this definition and export the new, correct, definition, although with CI passing I'm not sure what to think. Perhaps we should deprecate anyway, to be proper? Or am I misunderstanding? |
I thinks that the reason why the CI has not catch the ABI breaking fail is the same as @przemektmalon's reply in #11948. |
@intel/llvm-gatekeepers can this be merged? thanks |
Unrelated test failures:
|
A declaration of get_mip_level_mem_handle incorrectly took sycl::device as a parameter, which should have been a sycl::queue. This is now fixed.