Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][SYCL] Use std::make_unique instead of make_unique_ptr #12827

Merged
merged 3 commits into from
Feb 28, 2024
Merged

[NFC][SYCL] Use std::make_unique instead of make_unique_ptr #12827

merged 3 commits into from
Feb 28, 2024

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner February 26, 2024 20:37
@aelovikov-intel aelovikov-intel marked this pull request as draft February 26, 2024 21:24
@bader
Copy link
Contributor

bader commented Feb 27, 2024

This looks more like an "API-breaking" change rather a "non-functional" change.

@aelovikov-intel
Copy link
Contributor Author

This looks more like an "API-breaking" change rather a "non-functional" change.

How so? It's the same std::unique_ptr that crosses any boundary.

@bader
Copy link
Contributor

bader commented Feb 27, 2024 •
edited
Loading

This looks more like an "API-breaking" change rather a "non-functional" change.

How so? It's the same std::unique_ptr that crosses any boundary.

It removes a function template from sycl namespace, which is part of SYCL API users may use it their code.
make_unique_ptr should have been added to sycl::detail namespace.

@aelovikov-intel
Copy link
Contributor Author

make_unique_ptr should have been added to sycl::detail namespace.

Yes!

It removes a function template from sycl namespace, which is part of SYCL API users may use it their code.

See it now, thanks. Guess I'll have to restore it unless in preview mode. Can't imagine anyone sane actually using it though.

@bader
Copy link
Contributor

bader commented Feb 27, 2024

Guess I'll have to restore it unless in preview mode. Can't imagine anyone sane actually using it though.

I agree with both these statements. :)

@aelovikov-intel
Restore the API to avoid the break
ffce7f7 
Mark it as deprecated though
@aelovikov-intel
Remove #include <sycl/stl.hpp> references
fe1a824 
Didn't notice locally because the copy was left in build directory
@aelovikov-intel aelovikov-intel marked this pull request as ready for review February 27, 2024 23:38
@aelovikov-intel aelovikov-intel merged commit 17ded8c into intel:sycl Feb 28, 2024
13 checks passed
@aelovikov-intel aelovikov-intel deleted the use-make_unique branch February 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aelovikov-intel @bader @bso-intel