[NFCI][SYCL] Simplify property_key creation #12831
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| struct buffer_location_key | ||
| : oneapi::experimental::detail::compile_time_property_key< | ||
| oneapi::experimental::detail::PropKind::BufferLocation> { |
There was a problem hiding this comment.
Would that be always ABI compatible taking into account that some properties are used in sycl/source? E.g.: https://github.com/intel/llvm/blob/sycl/sycl/source/detail/usm/usm_impl.cpp#L98-L99
There was a problem hiding this comment.
The ones in that example are from SYCL 2020 properties, while these properties are all from the sycl_ext_oneapi_properties extension. Since that property-list is templated I don't believe it crosses the library boundaries, so it would only be if we pass the properties around by themselves.
| struct buffer_location_key | ||
| : oneapi::experimental::detail::compile_time_property_key< | ||
| oneapi::experimental::detail::PropKind::BufferLocation> { |
There was a problem hiding this comment.
The ones in that example are from SYCL 2020 properties, while these properties are all from the sycl_ext_oneapi_properties extension. Since that property-list is templated I don't believe it crosses the library boundaries, so it would only be if we pass the properties around by themselves.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
intel#12831 inadverdently removed the detail namespace opening from the GRF size property header. This commit returns this namespace. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
#12831 inadverdently removed the detail namespace opening from the GRF size property header. This commit returns this namespace. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
No description provided.