Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix EnableIfOutputIteratorT trait #12834

Closed
wants to merge 13 commits into from
Closed

[SYCL] Fix EnableIfOutputIteratorT trait #12834

Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bee45c3
Throw when USM not supported by Device
lbushi25 Jan 19, 2024
d11d72a
Merge branch 'intel:sycl' into sycl
lbushi25 Jan 19, 2024
4045d77
Merge branch 'intel:sycl' into sycl
lbushi25 Jan 23, 2024
8c9d3d2
Merge branch 'intel:sycl' into sycl
lbushi25 Jan 29, 2024
4745d35
Merge branch 'intel:sycl' into sycl
lbushi25 Jan 31, 2024
04595ad
Update usm_impl.cpp
lbushi25 Feb 9, 2024
a3cd857
Emit error when set_final_data called with non-const iterator
lbushi25 Feb 27, 2024
002d53d
Fix EnableIfOuputIteratorT
lbushi25 Feb 27, 2024
27f8294
Fix EnableIfOuputIteratorT
lbushi25 Feb 27, 2024
b69423f
Fix EnableIfOutputIteratorT
lbushi25 Feb 27, 2024
f01763a
Fix EnableIfOutputIteratorT
lbushi25 Feb 27, 2024
3e52d55
Update stl_type_traits.hpp
lbushi25 Feb 27, 2024
17e2860
Update stl_type_traits.hpp
lbushi25 Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sycl/include/sycl/detail/common.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ using EnableIfOutputPointerT = std::enable_if_t<

template <typename DataT>
using EnableIfOutputIteratorT = std::enable_if_t<
/*is_output_iterator<DataT>::value &&*/ !std::is_pointer_v<DataT>>;
/*is_output_iterator<DataT>::value &&*/ !std::is_pointer_v<DataT> &&
!std::is_const_v<std::remove_reference_t<
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Line 34 has the same bug.
  2. Have you checked if comment at line 30 is up-to-date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if its prossible to uncomment the is_output_iterator trait then I'll get back to you. If this is unblocked then this PR is done.

Copy link
Contributor Author

@lbushi25 lbushi25 Feb 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel It looks like the problem was with void* ptr so I added a full specialization for that case. This enabled me to uncomment the is_output_iterator. Let me know of any concerns!

typename std::iterator_traits<DataT>::reference>>>;

#if !defined(NDEBUG) && (_MSC_VER > 1929 || __has_builtin(__builtin_FILE))
#define __CODELOC_FILE_NAME __builtin_FILE()
Expand Down
Loading