Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] Avoid local memory initialization through group_local_memory_for_overwrite #12836

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Feb 27, 2024

group_local_memory becomes an issue for performance due to the initialization phase.
group_local_memory_for_overwrite allocates memory similarly without initialization, so, if initialization is needed, the user is now responsible for it.

More info: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/supported/sycl_ext_oneapi_local_memory.asciidoc

@Alcpz Alcpz requested a review from a team as a code owner February 27, 2024 12:20
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alcpz
Copy link
Contributor Author

Alcpz commented Feb 28, 2024

@intel/llvm-gatekeepers PR ready for merge! Thanks!

@sommerlukas sommerlukas merged commit d7fb328 into intel:sycl Feb 28, 2024
12 checks passed
@Alcpz Alcpz deleted the Alcpz/local_memory_for_overwrite branch February 28, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants