Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Implement sycl_ext_oneapi_profiling_tag extension #12838

Merged
merged 22 commits into from
May 30, 2024
Merged

[SYCL] Implement sycl_ext_oneapi_profiling_tag extension #12838

merged 22 commits into from
May 30, 2024

Conversation

steffenlarsen
Copy link
Contributor

This commit adds the implementation of the sycl_ext_oneapi_profiling_tag extension. Moving the extension to experimental will happen in a follow-up patch.

@steffenlarsen steffenlarsen reopened this Feb 29, 2024
@steffenlarsen steffenlarsen mentioned this pull request Mar 1, 2024
Merged
@steffenlarsen steffenlarsen mentioned this pull request Mar 5, 2024
Open
@steffenlarsen
[SYCL] Implement profiling tag extension
85f47a3 
This commit adds the implementation of the sycl_ext_oneapi_profiling_tag
extension. Moving the extension to experimental will happen in a
follow-up patch.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen marked this pull request as ready for review March 5, 2024 16:58
@steffenlarsen steffenlarsen requested review from a team as code owners March 5, 2024 16:58
PietroGhg
PietroGhg approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

ldrumm
ldrumm requested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of logic/enumerator questions worth checking but other than that, this looks good.

sycl/include/sycl/detail/pi.h Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/profiling_tag.hpp Show resolved Hide resolved
sycl/include/sycl/device_aspect_macros.hpp Outdated Show resolved Hide resolved
sycl/source/detail/scheduler/commands.cpp Outdated Show resolved Hide resolved
sycl/unittests/helpers/PiMockPlugin.hpp Show resolved Hide resolved
@steffenlarsen
Merge remote-tracking branch 'intel/sycl' into steffen/event_with_enq…
4b3f410 
…ueue
@steffenlarsen
Address comments
0e77ef7 
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from ldrumm May 14, 2024 05:49
@steffenlarsen
Copy link
Contributor Author

@ldrumm - Friendly ping.

@steffenlarsen
Copy link
Contributor Author

@ldrumm - Friendly ping.

1 similar comment
@steffenlarsen
Copy link
Contributor Author

@ldrumm - Friendly ping.

ldrumm
ldrumm approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ldrumm ldrumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies. I don't know why I didn't see your pings. Need to check my filters...

EwanC
EwanC approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steffenlarsen steffenlarsen merged commit 42fc5e9 into intel:sycl May 30, 2024
14 checks passed
steffenlarsen added a commit to steffenlarsen/llvm that referenced this pull request May 30, 2024
@steffenlarsen
[SYCL][E2E] Fix include of sycl/sycl.hpp in profiling tag tests
b2c9607 
An include of sycl/sycl.hpp snuck in with intel#12838.
This commit fixes this.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen mentioned this pull request May 30, 2024
Merged
@steffenlarsen
Copy link
Contributor Author

Failure due to include of sycl/sycl.hpp addressed by #13970.

@steffenlarsen
Copy link
Contributor Author

profiling_queue.cpp will be temporarily disabled for FPGA emulator while the failure is being investigated: #13971

steffenlarsen added a commit that referenced this pull request May 30, 2024
@steffenlarsen
[SYCL][E2E] Fix include of sycl/sycl.hpp in profiling tag tests (#13970)
8a33df3 
An include of sycl/sycl.hpp snuck in with
#12838. This commit fixes this.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This was referenced Aug 8, 2024
Open
Draft
@stgeke
Copy link

stgeke commented Sep 17, 2024

Is there an estimated timeline for when this feature will be available in an upcoming Intel compiler release?

@steffenlarsen
Copy link
Contributor Author

Hi @stgeke! Thank you for the interest. I cannot comment on the timeline, but this is expected to be part of the next compiler release.

@steffenlarsen steffenlarsen deleted the steffen/event_with_enqueue branch September 17, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroGhg PietroGhg PietroGhg approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@ldrumm ldrumm ldrumm approved these changes

@gmlueck gmlueck gmlueck approved these changes

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@EwanC EwanC EwanC approved these changes

@kbenzie kbenzie kbenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@steffenlarsen @gmlueck @EwanC @kbenzie @stgeke @cperkinsintel @ldrumm @AlexeySachkov @PietroGhg