Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN] Change barrier to use local fence #12846

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[GEN] Change barrier to use local fence #12846

merged 1 commit into from
Feb 28, 2024

Conversation

whitneywhtsang
Copy link
Contributor

@whitneywhtsang whitneywhtsang commented Feb 27, 2024 •
edited
Loading

We use genx.barrier to lower gpu.barrier and the latter doesn't have attributes to specify any fence scope. We should be fine using local fences for genx.barrier unconditionally for now.

@whitneywhtsang whitneywhtsang added the genx Pull requests or issues for genx branch label Feb 27, 2024
@whitneywhtsang whitneywhtsang requested a review from a team February 27, 2024 22:41
@whitneywhtsang
Copy link
Contributor Author

The change is authored by @ienkovich.

@whitneywhtsang whitneywhtsang mentioned this pull request Feb 27, 2024
Closed
@whitneywhtsang whitneywhtsang merged commit e65cd96 into intel:genx Feb 28, 2024
3 checks passed
@whitneywhtsang whitneywhtsang deleted the barrier branch February 28, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiotto etiotto etiotto approved these changes

Assignees
No one assigned
Labels
genx Pull requests or issues for genx branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitneywhtsang @etiotto