Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Doc] Clarify WI funcs in kernel compiler #12891

Commits on Mar 1, 2024

  1. Minor formatting fixes

    gmlueck committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d23be44 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    320a65e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d9afed6 View commit details
    Browse the repository at this point in the history
  4. Clarify iteration space and builtin vars in SPIR-V

    Also disallows launching a SPIR-V kernel as a simple "range" kernel.
    This seems consistent with our view that a "range" kernel is not just a
    degenerate form of an nd-range kernel.  Since SPIR-V kernels always
    have access to nd-range features, it does not make sense to launch them
    as range kernels.  This is also consistent with our decision to limit
    SYCL free function kernels to "nd-range" and "single-task" forms.
    gmlueck committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    99a06fd View commit details
    Browse the repository at this point in the history
  5. Align OpenCL kernel arg table with SPIR-V

    The OpenCL table describing legal kernel arguments had the opposite
    order from the corresponding SPIR-V table.  The OpenCL table listed
    the SYCL argument type in the left column while the SPIR-V table listed
    the SYCL argument tupe in the right column.  I like the SPIR-V format
    better, so change the OpenCL table to match.  This also adopts some of
    the same wording from the SPIR-V table into the OpenCL one.
    gmlueck committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8433e39 View commit details
    Browse the repository at this point in the history
  6. Clarify iteration space and work-item functions

    Clarify the iteration space and the user of work-item functions in the
    OpenCL spec.  These changes closely follow the corresponding changes in
    the SPIR-V spec.
    gmlueck committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ae01c9e View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    dd9fb98 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Reference C.7.7 when talking about index inversion

    Add a note referencing section C.7.7 of the core SYCL spec, which has
    more details about the inverted sense of SYCL dimensions compared to
    OpenCL.
    gmlueck committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    3960d76 View commit details
    Browse the repository at this point in the history
  2. Clarify single-task behavior

    Clarify that a single-task OpenCL and SPIR-V kernel can still use
    features like `local_accessor` and group functions.  These are
    well-defined because we already state that these single-task kernels
    are launched as nd-range kernels with 1 work-item.
    gmlueck committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    12baf15 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    957b991 View commit details
    Browse the repository at this point in the history
  2. Minor formatting change

    Use [source] block instead of triple backticks.
    gmlueck committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    51c0f9f View commit details
    Browse the repository at this point in the history