Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph][UR] Update UR to support updating kernel commands in command buffers for L0 #12897

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

againull
Copy link
Contributor

@againull againull commented Mar 4, 2024

No description provided.

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oneapi-src/unified-runtime#1353 has been merged, please pull in the latest sycl branch changes, fix the merge conflict, update the UR repo/tag, then make this ready to merge.

Comment on lines 59 to 60
set(UNIFIED_RUNTIME_REPO "https://github.com/againull/unified-runtime.git")
set(UNIFIED_RUNTIME_TAG c9be1e28d2e2a132e8a40d707175d6625d50d8f9 )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
set(UNIFIED_RUNTIME_REPO "https://github.com/againull/unified-runtime.git")
set(UNIFIED_RUNTIME_TAG c9be1e28d2e2a132e8a40d707175d6625d50d8f9 )
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit ca5c34213c3484072f32a9ab2b56b0f49ebe712e
# Merge: 4d0183a8 c9be1e28
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
# Date: Tue Mar 19 16:58:27 2024 +0000
# Merge pull request #1353 from againull/againull/l0_adapter_update_cmd_buffer
# [L0] Support updating kernel commands in command buffers
set(UNIFIED_RUNTIME_TAG ca5c34213c3484072f32a9ab2b56b0f49ebe712e)

@againull againull requested a review from kbenzie March 19, 2024 18:30
@againull againull changed the title [UR] Update UR to c9be1e [SYCL][Graph][UR] Update UR to support updating kernel commands in command buffers for L0 Mar 19, 2024
@againull againull marked this pull request as ready for review March 19, 2024 18:31
@againull againull requested a review from a team as a code owner March 19, 2024 18:31
@againull againull merged commit 1f9bf7a into intel:sycl Mar 19, 2024
12 checks passed
@againull againull deleted the ur_cmdlist_update branch April 9, 2024 19:56
kbenzie pushed a commit to kbenzie/llvm that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants