Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Docs] Invert group numbering for ballot groups #12905

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

steffenlarsen
Copy link
Contributor

The current extension for non-uniform groups state that ballot groups are numbered 0 if the predicate was true and 1 if the predicate was false. However, the implementation has the inverse numbering. This commit changes the extension to make the numbering consistent with the implementation, in turn making the group numbering directly convertible to a boolean value equal to the corresponding predicate.

The current extension for non-uniform groups state that ballot groups
are numbered 0 if the predicate was true and 1 if the predicate was
false. However, the implementation has the inverse numbering. This
commit changes the extension to make the numbering consistent with the
implementation, in turn making the group numbering directly convertible
to a boolean value equal to the corresponding predicate.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@Pennycook
Copy link
Contributor

While we're here, how would you feel about updating this line too, in the definition of get_local_range():

This will always return a range of 2, as there will always be two groups; one representing the group of work-items where the predicate was true and another representing the group of work-items where the predicate was false.

To say:

This will always return a range of 2, as there will always be two groups; one representing the group of work-items where the predicate was true and another representing the group of work-items where the predicate was false. It is possible for one of these groups to contain no work-items, if the predicate has the same value on all work-items.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen merged commit 90a55a5 into intel:sycl Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants