Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Libdevice] Split SYCL specific code in sanitizer libdevice #12915

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Mar 6, 2024

Current SYCL device sanitizer can be ported to other offloading solution such as openmp but sanitizer libdevice uses some SYCL specific macro or code which is only valid in SYCL scenario, this PR splits these code/macros.

Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Mar 6, 2024

Hi, @intel/llvm-reviewers-runtime
Could you help review this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Mar 7, 2024

Hi, @sergey-semenov
Could you take a look at this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Mar 9, 2024

Hi, @sergey-semenov
Sorry for bothering again, I just updated the patch to replace "#if SYCL_DEVICE_ONLY" with "#ifdef ..." just to unify with previous code. Could you approve again?
Thanks very much.

Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 requested a review from a team March 11, 2024 13:59
@jinge90
Copy link
Contributor Author

jinge90 commented Mar 11, 2024

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@dm-vodopyanov dm-vodopyanov changed the title [SYCL] Split SYCL specific code in sanitizer libdevice [SYCL][Libdevice] Split SYCL specific code in sanitizer libdevice Mar 11, 2024
@dm-vodopyanov dm-vodopyanov merged commit d669961 into intel:sycl Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants