Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Remove print to cout from aspect check #12978

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 11, 2024

  • Removes printing to cout from check for ext_oneapi_graph
  • Caused garbled output when running sycl-ls and LIT

- Removes printing to cout from check for ext_oneapi_graph
- Caused garbled output when running sycl-ls and LIT
@Bensuo Bensuo requested a review from a team as a code owner March 11, 2024 15:52
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was debug code that I forgot to remove in #12812

@EwanC
Copy link
Contributor

EwanC commented Mar 12, 2024

ping @intel/llvm-reviewers-runtime - a duplicate PR was opened with this fix (#12986) so would be good to get this in today to minimize disruption developers are experiencing.

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@EwanC
Copy link
Contributor

EwanC commented Mar 12, 2024

@intel/llvm-gatekeepers This is good to merge, thanks

@martygrant martygrant merged commit 3e14dc0 into intel:sycl Mar 12, 2024
13 checks passed
@Bensuo Bensuo deleted the ben/aspect_fix branch March 12, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants