Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][COMPAT] Added support for multiple math ops #13005

Merged
merged 8 commits into from
Apr 19, 2024

Conversation

Alcpz
Copy link
Contributor

@Alcpz Alcpz commented Mar 13, 2024

Adds support/wrapping around multiple math ops:

  • clamp
  • isnan
  • cbrt
  • min
  • max
  • fmax_nan
  • fmin_nan
  • pow
  • relu

@Alcpz Alcpz requested a review from a team as a code owner March 13, 2024 09:34
@Alcpz
Copy link
Contributor Author

Alcpz commented Mar 13, 2024

@zhiweij1 Tagging you since you provided insight for the min and max functions in a previous PR that has been closed.

Copy link

@zhiweij1 zhiweij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max/min part LGTM.

Copy link
Contributor

@AidanBeltonS AidanBeltonS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question

sycl/include/syclcompat/math.hpp Outdated Show resolved Hide resolved
@Alcpz Alcpz closed this Apr 19, 2024
@Alcpz Alcpz reopened this Apr 19, 2024
@Alcpz
Copy link
Contributor Author

Alcpz commented Apr 19, 2024

@intel/llvm-gatekeepers this PR is ready for merge. PR failure on windows unrelated (error in post register cleanup)

@steffenlarsen steffenlarsen merged commit 4ade7b7 into intel:sycl Apr 19, 2024
23 of 25 checks passed
@Alcpz Alcpz deleted the Alcpz/math-ops branch June 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants