[SYCL][COMPAT] Added 33 bit extend operations with and without saturation #13006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackAKirk
reviewed
Apr 3, 2024
|
|
||
| #ifdef SYCL_EXT_ONEAPI_BFLOAT16_MATH_FUNCTIONS | ||
| template <> | ||
| inline sycl::ext::oneapi::bfloat16 clamp(sycl::ext::oneapi::bfloat16 val, |
There was a problem hiding this comment.
Why not add these directly to the existing bfloat16 extension? So users don't need to mix and max namespaces?
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_bfloat16_math_functions.asciidoc
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
I've added a TODO regarding this. If SYCL users need this type for clamp, they should not go through the syclcompat version. If it gets added to the bfloat extension, it is sensible to remove this from syclcompat.
AidanBeltonS
approved these changes
Apr 10, 2024
|
@intel/llvm-gatekeepers this is ready for merging, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for addition, substraction, min, and max operations extended from 32 to 33 bit.
Adds an extra API for each operation where a transform binaryop can be applied to the result of the defined
extendoperation.