Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Make mutable swizzle functions unusable on const vec #13026

Closed
wants to merge 9 commits into from
Closed

[SYCL] Make mutable swizzle functions unusable on const vec #13026

wants to merge 9 commits into from

Commits on Mar 13, 2024

  1. [SYCL] Make swizzle mutating operators const friends 

    In intel#12682 the mutating operators for
swizzles (+=, -=, ..., ++, --) were reverted to be members rather than
friends. Since swizzles mutate the underlying vec rather than themselves
these operators should take and return constant references instead,
which this commit implements.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    950c083 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. [SYCL] Make mutable swizzle functions unusable on const vec 

    Swizzles should not expose mutating functions when the underlying vector
is const. This commit SFINAEs these out.

This is built on top of intel#13012.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3262f89 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Also disallow load for const vecs and make it const 

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    860ad1f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Use swizzle in load 

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed May 14, 2024
    Configuration menu
    Copy the full SHA
    331f1d0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'intel/sycl' into steffen/sfinae_const_v… 

    …ec_mutations
    @steffenlarsen
    steffenlarsen committed May 14, 2024
    Configuration menu
    Copy the full SHA
    99f3b15 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge remote-tracking branch 'intel/sycl' into steffen/sfinae_const_v… 

    …ec_mutations
    @steffenlarsen
    steffenlarsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f9b039a View commit details
    Browse the repository at this point in the history

  2. Fix tests 

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    396de3c View commit details
    Browse the repository at this point in the history

  3. Add missing include to test 

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    955c841 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge remote-tracking branch 'intel/sycl' into steffen/sfinae_const_v… 

    …ec_mutations
    @steffenlarsen
    steffenlarsen committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    0463306 View commit details
    Browse the repository at this point in the history