Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][PI] Add PI_ERROR_UNSUPPORTED_FEATURE error code #13036

Conversation

steffenlarsen
Copy link
Contributor

This commit adds a new error code to PI as a mapping from UR_RESULT_ERROR_FEATURE_UNSUPPORTED.

This relates to oneapi-src/unified-runtime#1448.

This commit adds a new error code to PI as a mapping from
UR_RESULT_ERROR_FEATURE_UNSUPPORTED.

This relates to oneapi-src/unified-runtime#1448.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@KornevNikita
Copy link
Contributor

Thanks Steffen! Just thought if we can make this error more clearer.
Just to notice - It looks like there are much more places where we can use this error-code instead of PI_ERROR_INVALID_OPERATION, e.g.:
https://github.com/intel/llvm/blob/sycl/sycl/source/detail/sycl_mem_obj_t.hpp#L273
https://github.com/intel/llvm/blob/sycl/sycl/source/detail/device_impl.cpp#L197
https://github.com/intel/llvm/blob/sycl/sycl/source/detail/scheduler/commands.cpp#L2319
and so on.

@steffenlarsen
Copy link
Contributor Author

Thanks Steffen! Just thought if we can make this error more clearer. Just to notice - It looks like there are much more places where we can use this error-code instead of PI_ERROR_INVALID_OPERATION, e.g.: https://github.com/intel/llvm/blob/sycl/sycl/source/detail/sycl_mem_obj_t.hpp#L273 https://github.com/intel/llvm/blob/sycl/sycl/source/detail/device_impl.cpp#L197 https://github.com/intel/llvm/blob/sycl/sycl/source/detail/scheduler/commands.cpp#L2319 and so on.

I agree that they could be replaced with the new error code, but I intentionally left them untouched as they are using deprecated exceptions and should be changed to using sycl::exception, which doesn't take a PI error code.

@steffenlarsen
Copy link
Contributor Author

@intel/dpcpp-nativecpu-pi-reviewers - Friendly ping.

Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

@steffenlarsen steffenlarsen merged commit 183832b into intel:sycl Mar 20, 2024
11 checks passed
kbenzie pushed a commit to kbenzie/llvm that referenced this pull request Apr 17, 2024
This commit adds a new error code to PI as a mapping from
UR_RESULT_ERROR_FEATURE_UNSUPPORTED.

This relates to oneapi-src/unified-runtime#1448.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants