Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Flip default printf implementation #13055

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[SYCL] Flip default printf implementation #13055

merged 2 commits into from
Mar 20, 2024

Commits on Mar 18, 2024

  1. [SYCL] Flip default printf implementation 

    Currently, the implementation of printf uses a variadic implementation
by default. This proved to be problematic as the implementation would
promote float arguments to doubles, implicitly requring fp64. As a
result of this, an alternative implementation was introduced, but was
made enableable using a __SYCL_USE_NON_VARIADIC_SPIRV_OCL_PRINTF__
directive to avoid problems with targets that did not support it. We
expect most relevant backends to support it now, so we flip the default.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d514f0f View commit details
    Browse the repository at this point in the history

  2. Fix check in in-tree test 

    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    @steffenlarsen
    steffenlarsen committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2864795 View commit details
    Browse the repository at this point in the history