-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Enable in-order cmd-list #13088
Conversation
2cd2081
to
e599f68
Compare
ffa958e
to
83904e0
Compare
Analyze the graph and apply enable the use of in-order command-list for linear graph. Add a property to finalize function to disable this optimization which is not compatible with profiling. Update the specification. Co-authored-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
83904e0
to
f8f0061
Compare
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
- checkIfGraphIsSinglePath returns bool - Design doc wording about optimizations
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Small nits.
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo nitpick but looks good otherwise 👍
Co-authored-by: Fábio <fabio.m.mestre@gmail.com>
ping @intel/unified-runtime-reviewers for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
Analyze the graph and apply enable the use of in-order command-list for linear graph. Add a property to finalize function to disable this optimization which is not compatible with profiling. Update the specification and tests.