Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Enable in-order cmd-list #13088

Merged
merged 14 commits into from
May 2, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Mar 21, 2024

Analyze the graph and apply enable the use of in-order command-list for linear graph. Add a property to finalize function to disable this optimization which is not compatible with profiling. Update the specification and tests.

Analyze the graph and apply enable the use of in-order command-list for linear graph.
Add a property to finalize function to disable this optimization which is not compatible with profiling.
Update the specification.

Co-authored-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
- checkIfGraphIsSinglePath returns bool
- Design doc wording about optimizations
@EwanC EwanC marked this pull request as ready for review April 30, 2024 10:45
@EwanC EwanC requested review from a team as code owners April 30, 2024 10:45
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Small nits.

sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@fabiomestre fabiomestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo nitpick but looks good otherwise 👍

sycl/unittests/Extensions/CommandGraph/Exceptions.cpp Outdated Show resolved Hide resolved
Co-authored-by: Fábio <fabio.m.mestre@gmail.com>
@EwanC
Copy link
Contributor

EwanC commented May 2, 2024

ping @intel/unified-runtime-reviewers for review

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
@martygrant martygrant merged commit 1665cc0 into intel:sycl May 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants