Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Deps] Uplift CPU/FPGAEMU RT version to 2024.17.3.0.09 #13261

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

yanfeng3721
Copy link
Contributor

@yanfeng3721 yanfeng3721 commented Apr 3, 2024

Uplift oclcpu/oclfpgaemu from 2023.16.10.0.17 to 2024.17.3.0.09

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner April 3, 2024 06:25
@yanfeng3721 yanfeng3721 marked this pull request as draft April 3, 2024 06:25
@yanfeng3721
Copy link
Contributor Author

yanfeng3721 commented Apr 7, 2024

For 3 regressions

Failed Tests (3):
  SYCL :: Assert/assert_in_kernels.cpp
  SYCL :: Basic/built-ins/marray_geometric.cpp
  SYCL :: KernelCompiler/kernel_compiler_spirv.cpp

Assert/assert_in_kernels.cpp is under investigation, Basic/built-ins/marray_geometric.cpp & KernelCompiler/kernel_compiler_spirv.cpp is expected cpurt version failures for cpurt 2024.17.3.0.09.
@aelovikov-intel, should we add "// XFAIL: cpu" for those expected failures? We can remove it for the next version cpurt uplift.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Apr 8, 2024

We can remove it for the next version cpurt uplift.

Is the fix ready? If so, why can't we update directly to it? If not, what makes you think the fix will be available during the next uplift and when is it expected to happen?

Or, in other words, I don't see any benefits to this project in uplifting CPURT to a newer version if it has new bugs and doesn't fix a substantially more important bug(s).

@yanfeng3721
Copy link
Contributor Author

Hi @aelovikov-intel , there are 4 tests can pass and 2 tests fail with oclcpurt 2024.17.3.0.09.

@yanfeng3721 yanfeng3721 requested a review from a team April 12, 2024 08:06
@yanfeng3721 yanfeng3721 marked this pull request as ready for review April 12, 2024 08:07
@yanfeng3721 yanfeng3721 requested review from a team as code owners April 12, 2024 08:07
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the changes.

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit f7b245f into intel:sycl Apr 16, 2024
17 checks passed
@bader
Copy link
Contributor

bader commented Apr 16, 2024

Post-commit failure:

e2e-lin (Intel Arc A-Series Graphics with Level Zero, ["Linux", "arc"], --param matrix-xmx8=True ... / Intel Arc A-Series Graphics with Level Zero summary
Failed Tests (1):
SYCL :: ESIMD/api/functional/functions/functions_select_2d_fp_extra.cpp

It doesn't seem to be related to the changes in this PR. The post-commit results for this configuration are quite unstable.

@againull
Copy link
Contributor

againull commented Apr 18, 2024

This also caused sycl-cts/math_builtin_float_half failure in nightly testing https://github.com/intel/llvm/actions/runs/8715677722/job/23908235101

Reported in internal tracker.

@yanfeng3721 yanfeng3721 deleted the uplift_ocl_cpurt_fpgaemurt branch June 20, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants