Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Remove deprecated interop interfaces #13306

Merged

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel added the abi-break change that's breaking abi and waiting for the next window to be able to merge label Apr 5, 2024
bool KeepOwnership =
BackendObject.Ownership == ext::oneapi::level_zero::ownership::keep;

return sycl::detail::make_context(NativeHandle, Handler,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously Handler was ignored - see

return detail::createSyclObjFromImpl<context>(
std::make_shared<context_impl>(PiContext, detail::defaultAsyncHandler,
Plugin, DeviceList, !KeepOwnership));
, this PR starts using it instead of defaultAsyncHandler.

BackendObject.Ownership == ext::oneapi::level_zero::ownership::keep,
BackendObject.Properties);
BackendObject.Properties, Handler, backend::ext_oneapi_level_zero);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, we were using async_handler from the TargetContext, see

return detail::make_queue(
NativeHandle, IsImmCmdList, Context, &Device, KeepOwnership, Properties,
ContextImpl->get_async_handler(), backend::ext_oneapi_level_zero);
. I'm updating to use the provided Handler, although I'm not sure about the consequences of that change. Regardless, using provided Handler instead of doing something completely different looks like a right thing to do for this interface.

@aelovikov-intel
Copy link
Contributor Author

@intel/unified-runtime-reviewers , @intel/llvm-reviewers-runtime , @sergey-semenov , ping.

@aelovikov-intel aelovikov-intel merged commit 0b59341 into intel:sycl Jun 28, 2024
14 checks passed
@aelovikov-intel aelovikov-intel deleted the remove-deprecated-interop branch June 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break change that's breaking abi and waiting for the next window to be able to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants