-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Remove deprecated interop interfaces #13306
[SYCL] Remove deprecated interop interfaces #13306
Conversation
bool KeepOwnership = | ||
BackendObject.Ownership == ext::oneapi::level_zero::ownership::keep; | ||
|
||
return sycl::detail::make_context(NativeHandle, Handler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously Handler
was ignored - see
llvm/sycl/source/backend/level_zero.cpp
Lines 58 to 60 in 3ea29b2
return detail::createSyclObjFromImpl<context>( | |
std::make_shared<context_impl>(PiContext, detail::defaultAsyncHandler, | |
Plugin, DeviceList, !KeepOwnership)); |
defaultAsyncHandler
.
BackendObject.Ownership == ext::oneapi::level_zero::ownership::keep, | ||
BackendObject.Properties); | ||
BackendObject.Properties, Handler, backend::ext_oneapi_level_zero); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before this change, we were using async_handler
from the TargetContext
, see
llvm/sycl/source/backend/level_zero.cpp
Lines 70 to 72 in 3ea29b2
return detail::make_queue( | |
NativeHandle, IsImmCmdList, Context, &Device, KeepOwnership, Properties, | |
ContextImpl->get_async_handler(), backend::ext_oneapi_level_zero); |
Handler
, although I'm not sure about the consequences of that change. Regardless, using provided Handler
instead of doing something completely different looks like a right thing to do for this interface.
a308501
to
d181c9a
Compare
d181c9a
to
942d0e4
Compare
942d0e4
to
8638027
Compare
@intel/unified-runtime-reviewers , @intel/llvm-reviewers-runtime , @sergey-semenov , ping. |
No description provided.