[DO NOT MERGE][ABI-Break][SYCL] ABI-neutralize exception constructor #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Byoungro So <byoungro.so@intel.com>
|
@steffenlarsen |
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Comment on lines
3
to
11
| // This file is intended be used to break dependency cycles due to | ||
| // exception.hpp. In some header files where exceptions are thrown, it has to | ||
| // #include <sycl/exception.hpp> which could lead to a cyclic dependency. In | ||
| // that case, it can utilize this work-around. This helper class is not intended | ||
| // to replace all throwing exception cases. | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
There was a problem hiding this comment.
I don't think you need to make it part of ABI: https://godbolt.org/z/bEbW181vn
There was a problem hiding this comment.
ABI-break is caused by changes to exception constructors, not because this new helper function.
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bso-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
I will close this PR when #13560 is merged. |
bso-intel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support ABI-neutral feature, a constructor of the sycl::exception class should take detail::string_view instead of std::string.
Also, to break cyclic dependencies, I introduced exception_helper.hpp/.cpp to throw an invalid parameter exception from the cpp file.