[CI] Add cron job to update IGC dev driver only #13412
Conversation
|
What is the process if the update isn't "green" in CI? How will we guarantee it will actually happen at least once a week? |
| - name: Determine parameters based on the day of the week | ||
| run: | | ||
| if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then | ||
| # Use the input dayofweek when manually triggered | ||
| DAY_OF_WEEK="${{ github.event.inputs.dayofweek }}" | ||
| else | ||
| # Use the current day of the week when triggered by a schedule | ||
| DAY_OF_WEEK=$(date +%u) | ||
| fi | ||
|
|
||
| if [ "$DAY_OF_WEEK" = "2" ]; then | ||
| PARAM="" | ||
| else | ||
| PARAM="--igc-dev-only" | ||
| fi | ||
| echo "PARAM=$PARAM" >> $GITHUB_ENV |
There was a problem hiding this comment.
I don't like this. I'd rather move common part into a re-usable workflow and then have two separate cron jobs in distinct .yml files. Also, why can't we just run the existing job frequently enough?
There was a problem hiding this comment.
Running existing job freq enough is also ok, but considering the situation of "red" CI -- it might not be realistic to push all driver update more than once per week.
But sure, I am more than happy to do so if we want to try updating ALL drivers more than once a week.
There was a problem hiding this comment.
I think the reason we do it once a week is simply because released version aren't updated that frequently and we wanted to avoid running unnecessary task. That said, if nothing is there to update, it should be very fast, so I don't see any reasons for us not to do that.
+ @bader maybe?
There was a problem hiding this comment.
That's right. NEO driver was released one a week in the past. These days, NEO release cadence is once a month.
That is a good question, I think we will need to provide some way to tolerate such situations -- eg: if we failed to download the old package, we skip the container update instead of failing. What do you think? |
I don't see any good solution here, sadly. My preference would be for the team(s) that want development builds of IGC to make a commitment to address any issues revealed in the update PR in 24 hours. Maybe we can modify the PR creation job to automatically add them as reviewers too. |
Sure, we can add them as reviewers, but I would say, there is not guarantee that the team can always address the issues in time. But if that is what we can do the best for now, I can update the job to add reviewers. |
I think we need first to get that commitment from them. If they won't commit, then we cannot make these changes in the CI at all until we find some other solution for the issue. |
@intel/sycl-matrix-reviewers Can you please comment on the commitment here . Thanks. |
@aelovikov-intel , @jsji , Instead, I'm suggesting the following:
|
|
Close this in favor of #13441. |
We have weekly cron job to update the IGC drivers.
However, the igc dev driver use CI driver from intel-graphic-compiler repo, the CI artifacts will be deleted if the build is 1 week or older, so we need to update the igc dev driver more frequently, eg: at least twice a week to make sure that the driver we use are new enough, or else we will fail to download the artifacts when doing install_driver test or updating the
devigcdocker contains.This is to add cron jobs to update igc dev driver only.
Tested: https://github.com/intel/llvm/actions/runs/8695012724