Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sycl_5_2_0: [SYCL][Bindless][Doc] Add support for cubemaps (#12996) #13471

Closed
wants to merge 21 commits into from

Commits on Apr 15, 2024

  1. [UR][L0] Support for urUsmP2PPeerAccessGetInfoExp to query p2p access… (

    intel#12983)
    
    … info
    
    pre-commit PR for
    oneapi-src/unified-runtime#1429
    
    ---------
    
    Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
    Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
    nrspruit and kbenzie committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    22e9785 View commit details
    Browse the repository at this point in the history
  2. [CUDA][LIBCLC] Implement RC11 seq_cst for PTX6.0 (intel#12516)

    Implement `seq_cst` RC11/ptx6.0 memory consistency for CUDA backend.
    
    See https://dl.acm.org/doi/pdf/10.1145/3297858.3304043 and
    https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#memory-consistency-model
    for full details. Requires sm_70 or above. With this PR there is now a
    complete mapping between SYCL memory consistency model capabilities and
    the official CUDA model, fully exploiting CUDA capabilities when
    possible on supported arches.
    
    This makes the SYCL-CTS atomic_ref tests fully pass for sm_70 on the
    cuda backend.
    
    Fixes intel#11208
    
    Depends on intel#12907
    
    ---------
    
    Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
    JackAKirk authored and kbenzie committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fa53fea View commit details
    Browse the repository at this point in the history
  3. [UR] Add urProgramGetGlobalVariablePointer entrypoint (intel#12496)

    Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
    fabiomestre and kbenzie committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0326cdc View commit details
    Browse the repository at this point in the history
  4. [SYCL][Graph][UR] Update UR to support updating kernel commands in co…

    …mmand buffers for L0 (intel#12897)
    againull authored and kbenzie committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a486c12 View commit details
    Browse the repository at this point in the history
  5. [UR] CI for UR PR refactor-guess-local-worksize (intel#12663)

    oneapi-src/unified-runtime#1326
    
    ---------
    
    Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
    hdelan and kbenzie committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0838aba View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. [SYCL][Graph][HIP] Set minimum ROCm version for graphs (intel#13035)

    Tests UR PR oneapi-src/unified-runtime#1447 that
    only reports support for UR command-buffers on ROCm 5.5.1 and later to
    work around HIP driver bugs related to HIP-Graph in earlier version.
    
    This requirement is also explicitly mentioned in the design doc.
    EwanC authored and kbenzie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    257ac92 View commit details
    Browse the repository at this point in the history
  2. [UR][L0] Fix Native Host memory usage on device with copy back sync (i…

    …ntel#13014)
    
    pre-commit PR for
    oneapi-src/unified-runtime#1439
    
    ---------
    
    Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
    Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
    nrspruit and kbenzie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    42919a9 View commit details
    Browse the repository at this point in the history
  3. [UR][L0] Enable default support for L0 in-order lists (intel#13033)

    Signed-off-by: Raiyan Latif <raiyan.latif@intel.com>
    Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
    raiyanla and kbenzie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1ba64e4 View commit details
    Browse the repository at this point in the history
  4. [SYCL][Graph][L0] Test Coverity fix (intel#13075)

    Bumps commit to UR PR
    oneapi-src/unified-runtime#1461
    EwanC authored and kbenzie committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    455c764 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1de8dbe View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c54bfe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6fd40bb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    30c1495 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a669736 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Configuration menu
    Copy the full SHA
    4627abf View commit details
    Browse the repository at this point in the history
  2. [UR][L0] Fix DeviceInfo global mem free to report unsupported given M…

    …emCount==0 (intel#13209)
    
    pre-commit PR for
    oneapi-src/unified-runtime#1486
    
    Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
    nrspruit authored and kbenzie committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    40c2781 View commit details
    Browse the repository at this point in the history
  3. [SYCL][PI] Add PI_ERROR_UNSUPPORTED_FEATURE error code (intel#13036)

    This commit adds a new error code to PI as a mapping from
    UR_RESULT_ERROR_FEATURE_UNSUPPORTED.
    
    This relates to oneapi-src/unified-runtime#1448.
    
    Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
    steffenlarsen authored and kbenzie committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1985ba5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. [Bindless][Exp][NFC] Remove Unnecessary 3D Array Image Helpers (inte…

    …l#13022)
    
    Remove accidental 3D image array intrinsic helpers as there is no NVVM
    IR supporting these.
    isaacault authored and kbenzie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e9ec31d View commit details
    Browse the repository at this point in the history
  2. [SYCL][Bindless][Doc] Add support for cubemaps (intel#12996)

    Add cubemap support:
     - Allocation and freeing of cubemapped images
     - Unsampled fetching and writing, and sampled reading
     - Device queries for cubemap support
     - Testing for both unsampled and sampled cubemap examples
     - Update the spec with cubemap support
    
    Remove `const` and `&` qualifiers from spec and implementation for
    handle parameters in `write_xxx` functions.
    
    Corresponding UR PR:
    oneapi-src/unified-runtime#1433
    
    ---------
    
    Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
    
    Resolved Conflicts in:
    - Due to not cherry-picking intel#12840
      - sycl/include/sycl/detail/pi.h
    - Due to not cherry-picking intel#13181
      - sycl/include/sycl/device_aspect_macros.hpp
      - sycl/include/sycl/info/aspects.def
    Seanst98 authored and kbenzie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    92e0423 View commit details
    Browse the repository at this point in the history
  3. [SYCL][Bindless][E2E] fix unsampled images test failure (intel#13007)

    * Update the test to initialize the input vectors with 0s to match
    `bindless_helpers::fill_rand` requirement of non empty vector.
    * Change the name of function `initVector` to  `init_vector`.
    * move `init_vector`, `equal_vec` and `operator<<` in header
    `bindless_helpers.hpp`.
    cppchedy authored and kbenzie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    b125ddf View commit details
    Browse the repository at this point in the history
  4. [SYCL][Bindless][E2E] fix missing scope when using equal_vec function (

    …intel#13229)
    
    * fix missed scope for `equal_vec` in Vulkan interop `mipmaps.cpp` test.
    cppchedy authored and kbenzie committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    74d213d View commit details
    Browse the repository at this point in the history