[SYCL][E2E] Fix some tests in multi-device mode #13510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alcpz
approved these changes
Apr 22, 2024
The atomic tests can be run by multiple SYCL devices, in which case the compiler needs to be told which device the `--cuda-gpu-arch` parameter applies to. The changes to the bfloat16 tests try and restore earlier behaviour, where the `aspect-ext_oneapi_bfloat16_math_functions` feature was preventing other devices from running. It also removes RUN lines from a shared header file (which we don't consider a valid test file) which may mislead people into thinking it itself is a runnable test.
frasercrmck
force-pushed
the
fix-cuda-sycl-backend-tests
branch
from
2e16309
to
7ce174a
Compare
JackAKirk
approved these changes
Apr 25, 2024
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Apr 25, 2024
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
This is ready for merging, @intel/llvm-gatekeepers, thanks |
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomic tests can be run by multiple SYCL devices, in which case the compiler needs to be told which device the
--cuda-gpu-archparameter applies to. This is done in the same vein as other occurrences of this parameter.The bfloat16 tests fail on some CPU devices due to a known issue with opaque pointers.