-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create one bitcode library for AMD and NVPTX #13930
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWehking
had a problem deploying
to
WindowsCILock
May 28, 2024 09:36
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
May 28, 2024 10:18
— with
GitHub Actions
Failure
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
May 29, 2024 12:57
c320369
to
6e2cbb0
Compare
MartinWehking
had a problem deploying
to
WindowsCILock
May 29, 2024 13:01
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
May 29, 2024 13:39
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
May 30, 2024 17:59
— with
GitHub Actions
Failure
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
June 18, 2024 15:08
56d6923
to
caa8999
Compare
MartinWehking
had a problem deploying
to
WindowsCILock
June 18, 2024 15:10
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 18, 2024 15:42
— with
GitHub Actions
Failure
MartinWehking
temporarily deployed
to
WindowsCILock
June 24, 2024 13:48
— with
GitHub Actions
Inactive
MartinWehking
had a problem deploying
to
WindowsCILock
June 25, 2024 13:31
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 25, 2024 15:07
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 25, 2024 15:40
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 26, 2024 18:09
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 27, 2024 10:01
— with
GitHub Actions
Error
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
June 27, 2024 10:16
93282e6
to
b408ef7
Compare
MartinWehking
had a problem deploying
to
WindowsCILock
June 27, 2024 10:17
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 27, 2024 16:18
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 28, 2024 13:21
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
June 28, 2024 15:02
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 3, 2024 09:58
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 3, 2024 19:00
— with
GitHub Actions
Failure
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
July 11, 2024 14:46
be9d4e0
to
5be595b
Compare
MartinWehking
had a problem deploying
to
WindowsCILock
July 11, 2024 14:47
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 17, 2024 12:41
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 18, 2024 10:48
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 18, 2024 15:24
— with
GitHub Actions
Failure
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
July 23, 2024 12:04
bf3aea8
to
57f4b8f
Compare
MartinWehking
had a problem deploying
to
WindowsCILock
July 23, 2024 12:05
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
July 24, 2024 14:23
— with
GitHub Actions
Failure
MartinWehking
temporarily deployed
to
WindowsCILock
August 5, 2024 13:29
— with
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
August 5, 2024 14:04
— with
GitHub Actions
Inactive
MartinWehking
had a problem deploying
to
WindowsCILock
August 6, 2024 14:10
— with
GitHub Actions
Error
MartinWehking
temporarily deployed
to
WindowsCILock
August 6, 2024 14:16
— with
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
August 6, 2024 15:24
— with
GitHub Actions
Inactive
Enable compilation of libdevice for AMD by adding AMDGCN to macro guarded code parts in libdevice for enabling e.g. standard library math function. Add compilation workflow to SYCLLibdevice.cmake for AMD. Create single bitcode libraries for AMD and NVPTX by compiling each libdev file into bitcode first, linking these together and running opt on them. Strip away metadata by reusing prepare_builtins from libclc and making the resulting library architecture independent. Remove NVPTX bundles from the libdev object files and remove any unbundling action spawned by the Clang driver for the SYCL toolchain when compiling for the NVPTX backend. Make the driver link against the single bitcode libraries for AMD and NVPTX for the SYCL toolchain when device library linkage is not excluded. Ensure that the clang tests check for the correctness of the new clang driver actions and check if the driver still links the device code against the itt device libraries when device library linkage has been excluded. Refactor SYCLLibdevice.cmake by creating functions and grouping e.g. the same compilation flags for a filetype together in one variable. Reuse these variables and call functions to remove redundancies. Fix a compilation error of Intel math function libraries for MSVC when targeting AMD. Include "device.h" before including "device_imf.hpp" to avoid the inclusion of <type_traits>, which failed with a redefinition of symbols error.
Do not select builtin LLVM intrinsics for AMDGCN by default. Previously, these intrinsics were selected by default and prevented linkage of standard library math functions provided by libdevice.
Test whether SYCL Codegen does not emit llvm intrinsics for amdgcn-amd-amdhsa and libdevice functions can be correctly linked later on.
MartinWehking
force-pushed
the
devicelib-bitcode-lib
branch
from
August 12, 2024 14:23
f39f0de
to
1ebfe17
Compare
MartinWehking
temporarily deployed
to
WindowsCILock
August 12, 2024 14:24
— with
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
August 12, 2024 14:57
— with
GitHub Actions
Inactive
Add the optimizer flags again that were previously removed.
MartinWehking
had a problem deploying
to
WindowsCILock
August 12, 2024 16:18
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
August 13, 2024 09:49
— with
GitHub Actions
Failure
MartinWehking
had a problem deploying
to
WindowsCILock
August 13, 2024 10:22
— with
GitHub Actions
Error
MartinWehking
temporarily deployed
to
WindowsCILock
August 13, 2024 10:51
— with
GitHub Actions
Inactive
MartinWehking
temporarily deployed
to
WindowsCILock
August 13, 2024 11:24
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable compilation of libdevice for AMD by adding AMDGCN to macro
guarded code parts in libdevice for enabling e.g. standard library
math function.
Add compilation workflow to SYCLLibdevice.cmake for AMD.
Create single bitcode libraries for AMD and NVPTX by compiling each
libdev file into bitcode first, linking these together and running
opt on them.
Strip away metadata by reusing prepare_builtins from libclc and making
the resulting library architecture independent.
Remove NVPTX bundles from the libdev object files and remove any
unbundling action spawned by the Clang driver for the SYCL toolchain
when compiling for the NVPTX backend.
Make the driver link against the single bitcode libraries for AMD and
NVPTX for the SYCL toolchain when device library linkage is not
excluded.
Do not select builtin LLVM intrinsics for AMDGCN by default to ensure
that stdlib functions can be found when linking against libdevice.
Ensure that the clang tests check for the correctness of the new
clang driver actions and check if the driver still links the device
code against the itt device libraries when device library linkage has
been excluded.
Refactor SYCLLibdevice.cmake by creating functions and grouping
e.g. the same compilation flags for a filetype together in one variable.
Reuse these variables and call functions to remove redundancies.
Fix a compilation error of Intel math function libraries for MSVC
when targeting AMD. Include "device.h" before including "device_imf.hpp"
to avoid the inclusion of <type_traits>, which failed with a
redefinition of symbols error.