Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC][SYCL] Minor refactoring in sycl::vec<> #13949

Merged
merged 16 commits into from
Jun 10, 2024
Merged

[NFC][SYCL] Minor refactoring in sycl::vec<> #13949

merged 16 commits into from
Jun 10, 2024

Conversation

uditagarwal97
Copy link
Contributor

Followup of and blocked by: #13947

Added comments + Rearranged code + Removed redundant MACRO

@uditagarwal97 uditagarwal97 self-assigned this May 29, 2024
@uditagarwal97 uditagarwal97 marked this pull request as ready for review June 7, 2024 22:01
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner June 7, 2024 22:01
maarquitos14
maarquitos14 reviewed Jun 10, 2024
View reviewed changes
sycl/include/sycl/vector_preview.hpp Show resolved Hide resolved
sycl/include/sycl/vector_preview.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/detail/vector_arith.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/detail/vector_arith.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/detail/vector_arith.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/detail/vector_arith.hpp Outdated Show resolved Hide resolved
@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers The PR is ready to be merged!

@againull againull merged commit f88d72e into intel:sycl Jun 10, 2024
14 checks passed
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@uditagarwal97 @ianayl
[NFC][SYCL] Minor refactoring in sycl::vec<> (intel#13949)
e15729e 
Follow-up of intel#13947

Added comments + Rearranged code + Removed redundant MACRO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uditagarwal97 @maarquitos14 @againull