[SYCL] Optimize vec<bfloat> math builtins #14106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
force-pushed
the
opt_math_builtins_2
branch
from
2951099
to
5f47483
Compare
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
The failure in Gen12 Windows is unrelated and likely an infrastructure issue. @intel/llvm-gatekeepers the PR is ready to be merged! |
Ahh.. I overlooked the pending review from @intel/dpcpp-tools-reviewers |
sarnex
approved these changes
Jun 24, 2024
|
Gen12 issue is #14248 but I restarted the job, I would prefer we run the tests before merging so we don't break postcommit. |
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup and blocked by: #14105
Currently,
vec<bfloat>math builtins do element-by-element operations.This PR optimize
vec<bfloat>math builtins by:(1) Converting
vec<bfloat>tovec<float>.(2) Do the operation on
vec<float>(which uses Spirv built-ins underneath for optimized vector operations).(3) Convert back the return value to
vec<bfloat>.Look at the beautiful diff in
check_device_code/vector/vector_bf16_builtins.cppto visualize the device code generated before and after this optimization.