-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM and SPIRV-LLVM-Translator pulldown (WW26 2024) #14327
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3091 commits
Select commit
Hold shift + click to select a range
43d207a
[RISCV][GISEL] IRTranslator for Scalable Vector Store (#86699)
jiahanxie353 431213c
[mlir][linalg] Implement patterns for reducing rank of named linalg c…
srcarroll 962d7ac
Add flag to opt out of wasm-opt (#95208)
mh4ck-Thales 0ab8198
[llvm-readobj][ELF] Implement JSON output for --dynamic-table (#95976)
feg208 58cb0e6
[.github] Add myself as a reviewer for DWARFLinker & friends (#96531)
JDevlieghere 0534953
[bazel] Port #95312 (#96533)
keith 33a9c57
[lldb] Fix failing TestFind(Ranges)InMemory.py tests. (#96511)
mbucko 2f69e9a
[COFF,test] Improve fission.ll
MaskRay b7b337f
[mlir] Use llvm::unique (NFC) (#96415)
kazutakahirata d6a3bd1
Update Clang extension criteria (#96532)
AaronBallman 2ae0905
[C23] Claim we do not conform to N2819
AaronBallman 62baf21
[AArch64] Check for streaming mode in HasSME* features. (#96302)
sdesmalen-arm 09c0337
[Clang][SveEmitter] Split up TargetGuard into SVE and SME component. …
sdesmalen-arm f2d3d82
[mlir][linalg][Transform] Fix use-after-free in `SplitOp::apply` (#96…
matthias-springer d30b082
[OpenMP] Add num_threads clause list format and strict modifier suppo…
TerryLWilmarth 0555afd
[NFC][MLInliner] Rename LastSCC -> CurSCC (#96546)
aeubanks b1a93db
[bazel] Export distributable lldb files (#96549)
keith b097018
[clang][OpenMP] Fix teams nesting of region check (#94806)
mikerice1969 313b1a8
[mlgo] Support composite AOT-ed models (#96276)
mtrofin 5413a2b
[clang][OpenMP] Fix error handling of the adjust_args clause (#94696)
mikerice1969 3aef525
[AMDGPU] Fix negative immediate offset for unbuffered smem loads (#89…
vangthao95 d2864d1
[libc++] Build with -fsized-deallocation (#96217)
ldionne bea7f3d
[libc][startup] create header for ElfW and use in startup (#96510)
nickdesaulniers dd8d978
[bazel] Switch mach_gen to apple_genrule (#96551)
keith a030c8b
[bazel] Add support for building lldb-dap (#96556)
keith 687d6fb
[NVPTX] Basic support for "grid_constant" (#96125)
akshayrdeodhar 5ae5069
LAA: strip unnecessary getUniqueCastUse (#92119)
artagnon 16903ac
[libc][math] Implement double precision sin correctly rounded to all …
lntue a32b719
Revert commits that add `TestFind(Ranges)InMemory.py` (#96560)
chelcassanova 75ac887
[BOLT][NFC] Sync CommandLineArgumentReference with options (#96563)
shawbyoung a3a44bf
[llvm][ProfDataUtils] Provide getNumBranchWeights API (#90146)
ilovepi 5e097c7
[BOLT] Hash-based function matching (#95821)
shawbyoung b3c668b
[clang][docs] '#pragma clang section' is supported on Mach-O. NFC
jroelofs 32e4906
Revert "[BOLT] Hash-based function matching" (#96568)
shawbyoung 0d4da0d
[lldb][API] Add Find(Ranges)InMemory() to Process SB API (#96569)
mbucko dc27ff1
[libc] Disable freelist test on NVPTX temporarily
jhuber6 361543e
[LLDB][Minidump] Change expected directories to the correct type; siz…
Jlalond a2d340b
Revert "[Flang][Driver] Add -print-resource-dir command line flag to …
DavidTruby 954b692
[flang] Allow derf as alternate spelling for erf (#95784)
DavidTruby 8ad32ce
[X86] Add sub-feature zu (zero upper) for APX
KanRobert 7ea63b9
[LoongArch][test] Remove the FIXME in psabi-restricted-scheduling.ll …
SixWeining b0e9b00
[NVPTX] Make nvptx mma instructions convergent. (#96521)
weiweichen 4e0a0ea
[X86] Fix test Clang::CodeGen/builtin-cpu-supports.c failure
KanRobert dd0b7cb
Merge from 'main' to 'sycl-web' (125 commits)
tianqingw 164e362
Merge from 'sycl' to 'sycl-web' (7 commits)
9267f8f
[clang-format] Add option to remove leading blank lines (#91221)
sstwcw 437366b
Adjust MSVC version range for ARM64 build performance regression (#90…
lxbndr c393121
[libc++] Remove Windows-specific configuration from libcxx/test/CMake…
ldionne 8348d72
[clang-tidy] Fix assert in performance-unnecessary-copy-init. (#96506)
legrosbuffle 1d9029f
Merge from 'main' to 'sycl-web' (17 commits)
tianqingw bd488c1
[RISCV] Use StringRef::starts_with(char) instead of starts_with(Strin…
topperc 8599629
[CodeGen][NewPM] Port machine post dominator tree analysis to new pas…
paperchalice 62d44fb
[MC] Remove setUseAssemblerInfoForParsing(false) workarounds
MaskRay f1e0657
[mlir][Transforms] Dialect conversion: Simplify handling of dropped a…
matthias-springer 41f8e6d
[RISCV][GISel] Fix test case order in fp-arith.mir. NFC
topperc 4c91b49
[clangd] Fix the build broken (NFC)
DamonFool efa8463
[VectorCombine] Add free concats to shuffleToIdentity. (#94954)
davemgreen f019581
[SmallPtrSet] Add remove_if() method (#96468)
nikic fa20184
[C++20] [Modules] [Serialization] Don't reuse type ID and identifier …
ChuanqiXu9 8153773
[clang][Interp] Fix returning primitive non-blockpointers
tbaederr 174f80c
[DomTree] Avoid duplicate hash lookups in runDFS() (NFCI) (#96460)
nikic 01fb529
Fix bazel after 18cf1cd92b554ba0b870c6a2223ea4d0d3c6dd21
ftynse 7f1a744
[TailDup][MachineSSAUpdater] Let RewriteUse insert a COPY when needed…
bjope 11e12bd
[NFC] [GWP-ASan] Rename Check() to check() (#96605)
hctim d782119
[Analysis] Use SmallPtrSet::remove_if (NFC)
nikic 2d84e0f
[RISCV] Add scheduling model for Syntacore SCR3 (#95427)
asi-sc 8395f9c
[lldb/DWARF] Remove parsing recursion when searching for definition D…
labath f6aa508
[SPIR-V]: Fix creation of constants of array types in SPIRV Backend (…
VyacheslavLevytskyy 0bd9c49
[AArch64][SVE] optimisation for SVE load intrinsics with no active la…
Lukacma 919b1ec
[flang][debug] Support pointer type. (#96153)
abidh 5feb32b
[AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lower…
vikramRH f9795f3
[GlobalISel] Add build methods for FP environment intrinsics (#96607)
spavloff 16d02cd
[libc++] Use __is_nothrow_destructible (#95766)
philnik777 29f4a05
[SetOperations] clang-format header (NFC)
nikic f09b024
[clang] Remove a stale FIXME
hokein 9d45077
[VPlan] Iterate over VPlans to get VFs to compute cost for (NFCI).
fhahn eeb0884
[LoopUnroll] Use poison instead of undef for preheader value
nikic a2e9157
[LV] Make create-induction-resume.ll more robust by adding store.
fhahn 37c736e
[LoopUnroll] Use poison instead of undef for another preheader value
nikic cc8fdd6
[Xtensa] Lower GlobalAddress/BlockAddress/JumpTable (#95256)
andreisfr 4acc8ee
[SCCP] Generate test checks (NFC)
nikic 16bb8c1
[SCCP] Use poison instead of undef when zapping returns
nikic 35eef9f
[Reassociate] Use poison instead of undef for dummy operands (NFCI)
nikic 65f9601
[NFC][lld][ELF] Remove unused `sec` param of `ObjFile<ELFT>::getReloc…
kovdan01 bfad875
[LoongArch] Ensure PseudoLA* can be hoisted (#94723)
heiher 9952e00
[VPlanTest] Use poison instead of undef for dummy values (NFC)
nikic 68efc50
[VectorBuilderTest] Use poison instead of undef for dummy values (NFC)
nikic 9acb533
[clang][Driver] Add HIPAMD Driver support for AMDGCN flavoured SPIR-V…
AlexVlx a46a2c2
[X86] Lower vXi8 multiplies using PMADDUBSW on SSSE3+ targets (#95690)
RKSimon 5ed5d72
[mlir][ArmSME] Lower multi-tile stores to a single loop (#96187)
MacDue 6c9916d
[libc] Configure CMAKE_REQUIRED_FLAGS so the GPU can use flag checks …
jhuber6 0f111ba
LoopInfo: introduce Loop::getLocStr; unify debug output (#93051)
artagnon 8263bec
[SLP] Use poison instead of undef in reorderScalars() (#96619)
nikic 952bdaa
[flang][OpenMP] Fix copyprivate allocatable/pointer lowering (#95975)
luporl c436649
[AArch64] Remove all instances of the 'hasSVEorSME' interfaces. (#96543)
sdesmalen-arm c5aa983
[InstSimplify] Fold all poison phi to poison instead of undef
nikic 4780dc3
[InstCombine] Add poison variant to phi test (NFC)
nikic abc8c4b
[LoopVectorize] Generate test checks (NFC)
nikic edbe698
[libc][math][c23] Add f16divf C23 math function (#96131)
overmighty eabe091
[bazel] Add missing dependency for 5ed5d723db58f7556782427444642d0571…
d0k 70cfece
Revert "[clang-format] Add option to remove leading blank lines (#912…
sstwcw c69ea04
Revert "[clangd] Fix the build broken (NFC)"
DamonFool fd62906
[libc++] Fix incorrect overflow checking in std::lcm (#96310)
ldionne 44c9a26
[Mem2Reg] Add tests with !noundef (NFC)
nikic c9f083a
[Clang][AMDGPU] Add builtins for instrinsic `llvm.amdgcn.raw.ptr.buff…
shiltian 1462605
[Analysis] Use range-based for loops (NFC) (#96587)
kazutakahirata 2dd4167
[LoopVectorize][AArch64] Add limited support for scalable vectorisati…
david-arm 54b61ad
[NFC][clang] Replace unreachable code in literal processing with asse…
mikerice1969 eb12d9b
[libc++] Remove the allocator<const T> extension (#96319)
ldionne d6c7410
AMDGPU: Remove an outdated TODO (#96446)
nhaehnle 7e9b49f
AMDGPU: Add plumbing for private segment size argument (#96445)
nhaehnle 13ed349
[AMDGPU][NFC] Rename AMDGPUVariadicMCExpr to AMDGPUMCExpr. (#96618)
kosarev fb463e1
[C23] Remove WG14 N2379 from the C status page
AaronBallman c6973ad
[Mem2Reg] Generate non-terminator unreachable for !noundef undef (#96…
nikic de528ff
[Flang] Extracting internal constants from scalar literals (#73829)
Leporacanthicus 2cf1975
[MLIR][OpenMP]Add order-modifier support to Order clause (#93805)
harishch4 a404529
[SPIRV] Add definitions for NonSemantic debug info (#95530)
bwlodarcz ec9ce89
[LoopVectorize] Fix build issue caused by #95920 (#96647)
david-arm 2274c66
[libc++] Use _If for conditional_t (#96193)
philnik777 ed1273d
[libc++] change the visibility of libc++ header to public in libcxx m…
RichardLuo0 bb5ab1f
[𝘀𝗽𝗿] initial version
shawbyoung 020f69c
Added opts::Lite to RewriteInstance
shawbyoung c097e64
Revert "Added opts::Lite to RewriteInstance"
shawbyoung 0e11a7e
[EarlyCSE] Add test with noundef load of undef (NFC)
nikic 79e8a59
[libc++] Move allocator assertion into allocator_traits (#94750)
huixie90 7f10ed6
[tsan] Fix dead lock when starting StackDepot thread (#96456)
vitalybuka dddef9d
[RISCV] Add FPR16 regbank and start legalizing f16 operations for Zfh…
topperc 8a46bbb
[Clang] Remove preprocessor guards and global feature checks for NEON…
Lukacma 8c11d37
[libc++] P3029R1: Better `mdspan`'s CTAD - `std::extents` (#89015)
xiaoyang-sde 902952a
Revert "[𝘀𝗽𝗿] initial version"
shawbyoung 731db06
[libc++] Get the GCC build mostly clean of warnings (#96604)
philnik777 2604830
Add support for __builtin_verbose_trap (#79230)
ahatanak bb075ee
[libc++] LWG3382: NTTP for `pair` and `array` (#85811)
JMazurkiewicz 889f3c5
AMDGPU: Handle legal v2bf16 atomicrmw fadd for gfx12 (#95930)
arsenm b7768c5
[clang][Interp][NFC] Use delegate() to delegate to only initlist item
tbaederr e951bd0
Reapply PR/87550 (again) (#95571)
oontvoo dca49d7
[libc][arm32] define argc type and stack alignment (#96367)
nickdesaulniers fb07afe
[BPF] Avoid potential long compilation time without -g (#96575)
yonghong-song ac1e22f
[mlir][vector] Generalize folding of ext-contractionOp to other types…
raikonenfnu 580343d
[clang][Interp][NFC] Destroy InitMap when moving contents to DeadBlock
tbaederr c9529f7
[mlir] Drop outermost dims in slice rank reduction inference (#95020)
Max191 05ca207
[C23] Update status page regarding FLT_MAX_EXP
AaronBallman d7dd778
[clang-doc] update install path to share/clang-doc instead of share/c…
PeterChou1 dbd5c78
[clang-doc] Remove stdexecpt from clang-doc test (#96552)
PeterChou1 f0f774e
[sanitizer] Rename DEFINE_REAL_PTHREAD_FUNCTIONS (#96527)
vitalybuka de7c139
[SLP] NFC. Refactor and add getAltInstrMask help function. (#94709)
HanKuanChen aaf50bf
[AMDGPU] Disallow negative s_load offsets in isLegalAddressingMode (#…
jayfoad 5e2beed
[C23] Move WG14 N2931 to the TS18661 section
AaronBallman 0b049ce
[tsan] Test `__tsan_test_only_on_fork` only on Mac (#96597)
vitalybuka 4c87212
[libc][thumb] support syscalls from thumb mode (#96558)
nickdesaulniers cd2bac8
[nfc][tsan] Better name for locking functions (#96598)
vitalybuka 0258a60
[nfc][tsan] Clang format includes (#96599)
vitalybuka 5c9513a
[NVPTX] cap param alignment at 128 (max supported by ptx) (#96117)
AlexMaclean 70fb1e3
Reland [mlir][Target] Improve ROCDL gpu serialization API (#96198)
fabianmcg c0dc134
[tsan] Lock/Unlock allocator and stacks on fork (#96600)
vitalybuka 39a0aa5
[SelectionDAG] Lower llvm.ldexp.f32 to ldexp() on Windows. (#95301)
efriedma-quic 928b780
[WebAssembly] Implement trunc_sat and convert instructions for f16x8.…
brendandahl a790279
[flang] Add basic -mtune support (#95043)
AlexisPerry a086933
[C11] Remove WG14 N1537 from the status page
AaronBallman 21ab32e
[lldb][LibCxx] Move incorrect nullptr check (#96635)
Michael137 b9353f7
[LinkerWrapper][NFC] Simplify StringErrors (#96650)
jhuber6 fef144c
Revert "[llvm] Use llvm::sort (NFC) (#96434)"
kazutakahirata aec735c
[Flang][OpenMP][MLIR] Fix common block mapping for regular and declar…
agozillon b003c60
[mlir][arith] Match folding of `arith.remf` to `llvm.frem` semantics …
ubfx a255ece
XFAIL llvm/test/DebugInfo/attr-btf_type_tag.ll on AIX (#96677)
nivethakuruparan ec2fb59
[BOLT][docs] Add Linux kernel optimization guide (#96669)
maksfb 8dd9494
Revert "[flang] Add basic -mtune support" (#96678)
tarunprabhu 7e77353
[clang][test] Avoid writing to a potentially write-protected dir (#96…
karka228 3f7b832
Merge from 'main' to 'sycl-web' (15 commits)
calebwat a55dc1d
[SLP][NFC]Add a test with the incorrect casting of the sext/zext alte…
alexey-bataev 600ff28
[mlgo] add 2 new features whether caller/callee is `available_externa…
mtrofin bd5b775
__asan_register_elf_globals: properly check the "no instrumented glob…
MaskRay 80114a7
[ScheduleDAG] Remove obsolete VReg2SUnitMap. NFC (#96559)
bjope 699cd9a
[llvm-dwp] Fix merging of debug_str_offsets with multiple contributio…
molar 228c2e1
[SLP]Fix incorrect promotion of nodes before shuffling.
alexey-bataev 3c24eb3
[LLVM][MIR] Support parsing bfloat immediates in MIR parser (#96010)
stephenchouca ef05b03
[libc][math][c23] Add MPFR exhaustive test for fmodf16 (#94656)
overmighty 88f80ae
[libc][math] Implement double precision cos correctly rounded to all …
lntue 04c2785
[MC,COFF] Change how we handle section symbols
MaskRay d264514
Enforce parameter order in f16 call, flipped call unit tests (#96258)
akshayrdeodhar 0280f97
[SLP]Fix PR95925: extract vectorized index of the potential buildvect…
alexey-bataev dff6871
[RISCV][GISel] Support G_FCONSTANT for Zfh.
topperc 7e59b20
[SCEV] Support addrec in right hand side in howManyLessThans (#92560)
mrdaybird edf5782
[TableGen] Check for duplicate register tuple definitions. (#95725)
nvjle 8bba070
AMDGPU: Expand testing of atomicrmw fmin/fmax lowering
arsenm 4f80f36
AMDGPU: Add new metadata and expand atomicrmw fadd expansion tests
arsenm e214ed9
[libc][arm] move setjmp+longjmp to fullbuild-only entrypoints (#96708)
nickdesaulniers 847235b
[RISCV] Add DAG combine to turn (sub (shl X, 8), X) into orc.b (#96680)
topperc 0d53366
APFloat: Add minimumnum and maximumnum (#96304)
wzssyqa 54ca5a8
[libc][fixedvector] Add const_iterator begin/end (#96714)
PiJoules e6c2216
Add ConstantRangeList::unionWith() and ::intersectWith() (#96547)
haopliu 6b29965
[clang-tidy] align all help message in run-clang-tidy (#96199)
HerrCai0907 fd7622a
Merge from 'sycl' to 'sycl-web' (10 commits)
calebwat 2f481f2
Merge from 'sycl' to 'sycl-web' (1 commits)
074e55c
Merge from 'main' to 'sycl-web' (125 commits)
ef86451
[mlir] Remove `*` from generic Linalg/Vector rules in CODEOWNERS (#96…
dcaballe a4fef26
[X86][FixupSetCC] Substitute setcc + zext pair with setzucc if possib…
KanRobert 55e60c3
[flang] Fix BoxAnalyzer.h for LLVM_ENABLE_EXPENSIVE_CHECKS (#96675)
dpalermo 811e505
[llvm][CodeGen] Update checking method of loop-carried phi in window …
huaatian 0fe82ea
gn build: Add missing source files to hwasan library.
pcc 96b1f88
[ORC] Remove redundant locking of session mutex, update method name.
lhames 896dd32
[ORC] Fix block dependence calculation in ObjectLinkingLayer.
lhames b347a72
[MC/DC][Coverage] Make tvbitmapupdate capable of atomic write (#96042)
chapuni f71f95d
[ELF] Rename IsRela to HasAddend
MaskRay 174d353
[X86] Fix description for pass X86FixupSetCC.cpp, NFCI
KanRobert 21bfc0e
Revert "[X86] Fix description for pass X86FixupSetCC.cpp, NFCI"
KanRobert 9253ac2
[X86] Fix description for pass X86FixupSetCC.cpp, NFCI
KanRobert 89d8df1
CodeGen, IR: Add target-{cpu,features} attributes to functions create…
pcc 658b9a4
Fix tests after cbf6e93ce (#14294)
jsji 0572254
[NFC] Update test to reflect expect optimization settings with clang-…
mdtoguchi 30a6284
[SYCL] Fix Clang :: Driver/sycl-offload-new-driver.c test failure. (#…
tianqingw bfd63e6
Fix conflicts due to 95061 (#14311)
iagarwa 51f0e21
[SYCL] Integrate the newly-added llvm.tan and llvm.experimental.const…
tianqingw 8237b4b
Merge from 'sycl' to 'sycl-web' (17 commits)
fa48dbd
Merge from 'main' to 'sycl-web' (116 commits)
iagarwa 760261d
Merge remote-tracking branch 'origin/sycl-web' into llvmspirv_pulldown
sys-ce-bb eaea1d8
Update constant-vars test after LLVM GEP change (#2593)
svenvh ec826c5
Add automated release workflow (#2586)
ZzEeKkAa 6edbfe1
Round up #elts of TypeVector when calculating memory size (#2504)
LU-JOHN 170f860
Update complex-constexpr.ll (#2594)
MrSidims f1e0207
Avoid requiring C++20 (#2600)
LU-JOHN 09dea92
Fix image access in link-attribute test (#2598)
svenvh 093352b
Add support for multiple Intel cache controls on a single argument (#…
MrSidims d0f0838
Update few tests check lines to use debug records (#2602)
MrSidims 1a321de
Make assertion precise (#2596)
LU-JOHN f455245
Fix missing includes (#2605)
svenvh fad9949
test: Fix x86 tests to use -mtriple=x86_64-unknown-linux-gnu (#2555)
mattst88 7c8cb41
Fix SPV_INTEL_runtime_aligned implementation part 1 (#1796)
MrSidims 061de13
True Label and False Label of an OpBranchConditional must not be the …
vmaksimo de4b365
Update DebugInfo test after LLVM section symbol change (#2607)
svenvh 6f707a4
Fix target id in decorates when there is forward decl (#2606)
wenju-he 0378786
Adjust SYCLLowerIR tests to account for the new debug format
calebwat 5465207
[SYCL][Test] Generate kernel-param test using script (#22546)
jsji 2540696
[SYCL][thinLTO] Seperate module properties and symbol table generatio…
sarnex 209ca8e
[SYCL] Add PassInstrumentation header in ComputeModuleRuntimeInfo
calebwat 2b950a0
Merge branch 'sycl' into llvmspirv_pulldown
calebwat 73b3c3f
[SYCL] Update clang verification checks to use fully qualified class …
calebwat f48bae2
[SYCL] Adjust additional test for clang verification
calebwat 15eb8cf
[NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (#96962)
jsji 97e43dd
[SYCL][E2E] Fix Wmissing-template-arg-list-after-template-kw warnings
sys-ce-bb 4e6a414
llvm-spirv: update test due to entry point diff
sys-ce-bb 2515f6f
llvm-spirv: XFAIL RuntimeAligned.spt test
sys-ce-bb a5f1d63
[SYCL][Test] Update test due to GEP folding change
sys-ce-bb f2f3acc
[SYCL] Update sycl-offload-new-driver due to order diff
sys-ce-bb 7820702
[Clang] Don't hardcode opnumber in module test
sys-ce-bb 3d2a5ba
Merge branch 'sycl' into llvmspirv_pulldown
sys-ce-bb 14abd9b
Merge branch 'sycl' into llvmspirv_pulldown
sys-ce-bb a159325
Remove unecessary include that require c++20
sys-ce-bb 25f12ff
Merge branch 'sycl' into llvmspirv_pulldown
sys-ce-bb 7a7619d
Fix conflict resolution for SPV_INTEL_runtime_aligned patch
vmaksimo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @MrSidims here, because this looks like a plain bug in the test, i.e. this change should be upstreamed later.
Both
testandtest_gepare kernels and therefore should be represented asEntryPointinstruction in SPIR-V. There could be anOpNameinstruction referencing them as well, but it is a part of debug info and it can be safely removed from the module. It is just a coincidence that the test works using it.I assume that the same change will be applied in the upstream translator and therefore it looks ok to me to proceed with it at intel/llvm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a bug in the test, it's a missing patch in intel/llvm (AFAIK it's being restored, it was missing due to lack of support in IGC).
Basically the missing patch was doing to following: for every kernel function it is creating a wrapper entry point that calls the function with the code copied form the original kernel. It was done because OpenCL allows one kernel to call another kernel and to comply the requirement from SPIR-V spec that one EntryPoint must not call another EntryPoint, we had to create such wrapper (actually, translator's community has done it for us).