[NFC] Describe sycl-post-link support for dynamic linking #14337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu, John <john.lu@intel.com>
|
Updated text describes current behavior of sycl_post_link. The previous text for sycl_post_link may need more revision. |
Signed-off-by: Lu, John <john.lu@intel.com>
|
@AlexeySachkov and @asudarsa kindly ping. I will approve after. |
sycl/doc/design/SharedLibraries.md
Outdated
| In typical device code splitting, all dependent device code is brought into a split | ||
| image in order to construct a complete image. This is impossible with dynamic linking | ||
| since the dynamic library may rely on functions that are not defined in the library. | ||
| Thus, when supporting dynamic linking a dependency to a canBeImportedFunction will not |
There was a problem hiding this comment.
Suggested change
| Thus, when supporting dynamic linking a dependency to a canBeImportedFunction will not | |
| Thus, when supporting dynamic linking a dependency to a `canBeImportedFunction` will not |
There was a problem hiding this comment.
Can we please avoid the use of 'canBeImportedFunction' here. It makes the document a bit unreadable.
asudarsa
reviewed
Jul 3, 2024
Signed-off-by: Lu, John <john.lu@intel.com>
cperkinsintel
approved these changes
Jul 12, 2024
KseniyaTikhomirova
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe behavior of sycl-post-link in support of dynamic linking