Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Disable 2 tests failing on new driver #14388

Merged
merged 2 commits into from
Jul 3, 2024
Merged

[SYCL] Disable 2 tests failing on new driver #14388

merged 2 commits into from
Jul 3, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jul 2, 2024 •
edited
Loading

#14376 tracked in #14387

The two fail tests will XPASS here because I haven't merged the driver change, I will do it immediately after this PR is merged

Failed Tests (2):
  SYCL :: Basic/image/srgba-read.cpp
  SYCL :: syclcompat/launch/launch.cpp

@sarnex
[SYCL] Disable 2 tests failing on new driver
2131ba2 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review July 2, 2024 15:50
@sarnex sarnex requested review from a team as code owners July 2, 2024 15:50
@sarnex
Copy link
Contributor Author

sarnex commented Jul 2, 2024

@intel/syclcompat-lib-reviewers Any chance I can get a quick review on this one? Thanks!

@bader
Copy link
Contributor

bader commented Jul 2, 2024

Does anyone know if REQUIRES-INTEL-DRIVER can be used to keep this test enabled if we test on the system with "good" driver?

@sarnex
Copy link
Contributor Author

sarnex commented Jul 2, 2024 •
edited
Loading

@aelovikov-intel correct me if I'm wrong but I think REQUIRES-INTEL-DRIVER is strictly a greater than equal to check, so we couldn't use it as is.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Jul 2, 2024 •
edited
Loading

@aelovikov-intel correct me if I'm wrong but I think REQUIRES-INTEL-DRIVER is strictly a greater than equal to check, so we couldn't use it as is.

Yeah, I think the current implementation only works for bad->good change along the time axis and not good->bad...

joeatodd
joeatodd approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@joeatodd joeatodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please ping us on the following PR 👍

@sarnex sarnex merged commit 25c41fe into intel:sycl Jul 3, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@joeatodd joeatodd joeatodd approved these changes

@maarquitos14 maarquitos14 Awaiting requested review from maarquitos14 maarquitos14 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarnex @bader @aelovikov-intel @joeatodd