Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add implicit queue recording mechanism #14453

Merged
merged 17 commits into from
Aug 8, 2024
Merged

[SYCL][Graph] Add implicit queue recording mechanism #14453

merged 17 commits into from
Aug 8, 2024

Conversation

fabiomestre
Copy link
Contributor

Updates the semantics of the record & replay API to allow queues to be
implicitly set to recording mode when submitting command-groups
that contains dependencies from other recording queues.

@fabiomestre fabiomestre mentioned this pull request Jul 4, 2024
Closed
@fabiomestre fabiomestre force-pushed the fabio/implicit_queue_recording branch from 4f126ed to 99c5bb3 Compare July 12, 2024 17:37
Bensuo
Bensuo reviewed Jul 17, 2024
View reviewed changes
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Show resolved Hide resolved
sycl/source/handler.cpp Outdated Show resolved Hide resolved
sycl/source/handler.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/test-e2e/Graph/RecordReplay/transitive_queue.cpp Outdated Show resolved Hide resolved
@fabiomestre fabiomestre marked this pull request as ready for review July 29, 2024 18:40
@fabiomestre fabiomestre requested review from a team as code owners July 29, 2024 18:40
EwanC
EwanC approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice testing too

sycl/test-e2e/Graph/RecordReplay/transitive_queue.cpp Outdated Show resolved Hide resolved
@EwanC EwanC mentioned this pull request Jul 31, 2024
Open
reble
reble approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@reble reble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabiomestre
Copy link
Contributor Author

@intel/llvm-gatekeepers Would it be possible to merge this? The HIP job in CI does not seem to be working at the moment.

@fabiomestre
Copy link
Contributor Author

@intel/llvm-gatekeepers This should be ready to be merged.

@sommerlukas sommerlukas merged commit bdecdd2 into intel:sycl Aug 8, 2024
14 checks passed
EwanC added a commit to reble/llvm that referenced this pull request Aug 26, 2024
@EwanC
[SYCL][Graph] enable_shared_from_this refactor
9f41405 
Use `std::enable_shared_from_this` to remove need for passing
a shared pointer of `this` as a function parameter.

`std::enable_shared_from_this` usage was previously introduced
to graph code in intel#14453 (comment)
@EwanC EwanC mentioned this pull request Aug 26, 2024
Merged
steffenlarsen pushed a commit that referenced this pull request Aug 30, 2024
@EwanC
[SYCL][Graph] enable_shared_from_this refactor (#15195)
f04c79b 
Use `std::enable_shared_from_this` to remove need for passing a shared
pointer of `this` as a function parameter.

`std::enable_shared_from_this` usage was previously introduced to graph
code in #14453 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@againull againull againull approved these changes

@Bensuo Bensuo Bensuo approved these changes

@reble reble reble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fabiomestre @EwanC @reble @Bensuo @againull @sommerlukas