Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][SYCL][Do not merge] Add CI workflow to run compute-benchmarks on incoming syclos PRs #14454

Draft
wants to merge 49 commits into
base: sycl
Choose a base branch
from

Conversation

ianayl
Copy link
Contributor

@ianayl ianayl commented Jul 4, 2024

This PR is a WIP github workflow that benchmarks a given branch using compute-benchmarks. It is currently in the midst of a massive overhaul.

Comment on lines 371 to 377
- name: Upload sycl-bench microbenchmark results
if: inputs.tests_selector == 'benchmark' && steps.run_benchmarks.outcome == 'success'
uses: actions/upload-artifact@v4
with:
name: sycl_benchmark_res_${{ steps.run_benchmarks.outputs.TIMESTAMP }}
path: ${{ steps.run_benchmarks.outputs.BENCHMARK_RESULTS }}
retention-days: 7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't very useful. I'd hope there are some GH actions that can draw some graphs with performance data of the project over time (if that data is "reported" properly to it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review Andrei! Udit and I were talking about graphing this a while back: As of right now this workflow has not yet been approved, as many details regarding the workflow needs to be hashed out. However, we do plan on graphing this data if this workflow gets approved.

The current idea that I have is to store/cache benchmarks periodically over time as long-term artifacts, and then graphing it using either a python or js action. Although, I have yet to sort out the details. This may potentially be janky, so I'm open to new ideas.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are yet to decide whether we will keep sycl-bench in intel/llvm CI. I guess we will also be exploring other micro benchmarking suites to find the ones appropriate for our use. This POC PR was just to evaluate the time it takes to run sycl-bench in CI.

@ianayl ianayl changed the title [CI][SYCL] Add PoC CI workflow to run sycl-bench micro-benchmarking suite [CI][SYCL][Do not merge] Add CI workflow to run compute-benchmarks on incoming syclos PRs Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants