[sycl][hip] Exception for unsupported get_native<sycl::context> #14476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
changed the title
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
…kAKirk/llvm into test-ur-hip-context-refactor
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
I'll update the FetchUnifiedRuntime to resolve conflicts once approvals are given and oneapi-src/unified-runtime#1830 has been merged. |
|
Hi @uditagarwal97 |
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Also made exception use feature_not_supported Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 20, 2024
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
reviewed
Sep 23, 2024
| # Date: Tue Sep 17 10:31:44 2024 +0200 | ||
| # Merge pull request #2087 from nrspruit/fix_driver_inorder_event_wait | ||
| # [L0] Fix urEnqueueEventsWaitWithBarrier for driver in order lists | ||
| set(UNIFIED_RUNTIME_TAG 0ac56783090f481081edea84bacc236092a0f695) |
There was a problem hiding this comment.
oneapi-src/unified-runtime#1830 has been merged, please update
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
JackAKirk
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
JackAKirk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Sep 24, 2024
|
@intel/llvm-gatekeepers please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add exception for unsupported get_nativesycl::context specialization for HIP backend.
This was previously marked deprecated. We keep the specialization in order to give an error message to users.