[SYCL] More cleanup to use SYCL 2020 exception
#14510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of deprecated SYCL 1.2 subclasses that we're going to remove during this ABI breaking window.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Jul 10, 2024
| @@ -40,9 +40,8 @@ static void cpuid(uint32_t *CPUInfo, uint32_t Type, uint32_t SubType = 0) { | |||
| #endif | |||
|
|
|||
| uint32_t PlatformUtil::getMaxClockFrequency() { | |||
There was a problem hiding this comment.
Unrelated to this PR, but I don't see any uses of this left, we should remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of deprecated SYCL 1.2 subclasses that we're going to remove during this ABI breaking window. In many cases there is no clear choice of using
errc::runtimevserrc::invalidor something else. I tried to use my best judgement. Reviewers, feel free to start inline discussions in comments if you disagree with my choice(s).