-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Move proposed sycl_ext_oneapi_group_sort extension to experimental #14531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
againull
commented
Jul 11, 2024
•
edited
Loading
edited
- Align proposed sycl_ext_oneapi_group_sort extension extension with the implementation. [69e5edb]
- Move proposed extension to experimental directory because it was implemented. [b6aceb7]
- Remove the first version of API and update feature macro. [2e7c080]
againull
force-pushed
the
move_sort_to_experimental
branch
from
July 17, 2024 22:05
9cfd1ea
to
4c86129
Compare
againull
force-pushed
the
move_sort_to_experimental
branch
from
July 17, 2024 22:34
4c86129
to
6f2c2d1
Compare
againull
force-pushed
the
move_sort_to_experimental
branch
from
July 17, 2024 22:46
6f2c2d1
to
2e7c080
Compare
tag @andreyfe1 |
sergey-semenov
approved these changes
Jul 18, 2024
@intel/dpcpp-specification-reviewers Could you please take a look, thank you! |
gmlueck
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec changes OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.