-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Driver][SYCL] Handle invalid characters from device in temp files #14563
Changes from all commits
0636c88
b07237e
7eb0095
c6d1f22
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
// Test valid file names from -device values for GPU | ||
// REQUIRES: system-windows | ||
|
||
// RUN: %clang -### --target=x86_64-pc-windows-msvc -fsycl \ | ||
// RUN: -fsycl-targets=spir64_gen --offload-new-driver \ | ||
// RUN: -Xsycl-target-backend "-device arch1:arch2" %s 2>&1 \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the behavior when the device arch values are comma separated or space separated? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The strings are not modified. Now, using commas is fine for file names AFAIK, but this could throw a wrench into the @asudarsa, any thoughts on how we can handle comma separated arch values when passed in like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @srividya-sundaram, I have added some additional changes to convert commas. Additional side discussions to be had with @asudarsa to resolve other issues with the packager. |
||
// RUN: | FileCheck %s -check-prefix=CHECK_COLON | ||
|
||
// CHECK_COLON: sycl-windows-device-filename-arch1@arch2 | ||
// CHECK_COLON: arch=arch1:arch2 | ||
// CHECK_COLON-NOT: sycl-windows-device-filename-arch1:arch2 | ||
|
||
// RUN: %clang -### --target=x86_64-pc-windows-msvc -fsycl \ | ||
// RUN: -fsycl-targets=spir64_gen --offload-new-driver \ | ||
// RUN: -Xsycl-target-backend "-device *" %s 2>&1 \ | ||
// RUN: | FileCheck %s -check-prefix=CHECK_STAR | ||
|
||
// CHECK_STAR: sycl-windows-device-filename-@ | ||
// CHECK_STAR: arch=* | ||
// CHECK_STAR-NOT: sycl-windows-device-filename-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an additional comma here
arch=pvc,bdw,
Is this expected or is this the issue you were referring to in your comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of now, it is expected and we will resolve with discussions with Arvind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can create a GitHub issue and link that to this PR.