[SYCL] Re-apply task sequence changes #14750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aejjehint
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
smanna12
approved these changes
Jul 25, 2024
mdtoguchi
reviewed
Jul 25, 2024
|
@steffenlarsen, @AlexeySachkov, @GarveyJoe, could you please review this PR? Thank you |
steffenlarsen
changed the title
steffenlarsen
approved these changes
Jul 26, 2024
sycl/include/sycl/ext/intel/experimental/fpga_kernel_properties.hpp
Outdated
Show resolved
Hide resolved
sycl/test/check_device_code/task_sequence_intel_explicit_get.cpp
Outdated
Show resolved
Hide resolved
sycl/test/check_device_code/task_sequence_intel_no_explicit_get.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
…t.cpp Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
AlexeySachkov
approved these changes
Jul 26, 2024
|
@intel/llvm-gatekeepers PR is ready to merge |
|
Notified @aejjehint about post-commit failures: https://github.com/intel/llvm/actions/runs/10117762715/job/27983612239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-apply the task sequence changes from PR #12453 that were reverted in #14359 now that the spec has been approved and the back-end implementation is ready. The spec is also moved from proposed to experimental.