Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix CI issues caused by recent UR version bump #14796

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Jul 26, 2024

hwloc became a dependency after #13343 was merged. CI infrastructure has been updated to have hwloc installed, but it's still missing on macOS runner.

Additionally, UMF compile options caused errors on SYCL runners that should be resolved after UR version bump included in this patch.

Logs: https://github.com/intel/llvm/actions/runs/10106492701/job/27948711331 and https://github.com/intel/llvm/actions/runs/10106492701/job/27948711538.

This version bump includes fixes that should resolve post-commit CI
errors.
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the description to mention that this now also includes a UR update that has a fix for the warning.

@kswiecicki kswiecicki changed the title [CI] Install hwloc dependency on macOS runner [CI] Fix CI issues caused by recent UR version bump Jul 26, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Jul 26, 2024

@intel/dpcpp-devops-reviewers please review. This fixes post commit jobs.

@steffenlarsen
Copy link
Contributor

As per offline sync with @kbenzie, we will let this through before the PI removal to get post-commit up again.

@steffenlarsen steffenlarsen merged commit 0119d48 into intel:sycl Jul 26, 2024
22 checks passed
@maksimsab
Copy link
Contributor

maksimsab commented Jul 26, 2024

Hi all.

JFYI, @kswiecicki.
I've started getting the following error locally after this commit:

-- Checking for module 'hwloc>=2.3.0'
--   No package 'hwloc' found
-- Checking for module 'libhwloc' using find_library()
CMake Error at /localdisk2/msabiani/llvm/build/_deps/unified-memory-framework-src/cmake/FindLIBHWLOC.cmake:71 (message):
  libhwloc NOT found (set CMAKE_PREFIX_PATH to point the location)
Call Stack (most recent call first):
  /localdisk2/msabiani/llvm/build/_deps/unified-memory-framework-src/CMakeLists.txt:100 (find_package)


-- Configuring incomplete, errors occurred!

UPD: Rolling back to the commit before #13343 helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants