Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][XPTI] Improvements to allow framework/app software level layers to provide code locations for sycl generated XPTI events. #15190

Merged
merged 11 commits into from
Oct 7, 2024

Commits on Aug 26, 2024

  1. [SYCL][XPTI] Honor code location set in TLS by application layer

    It is useful for framework software layers which uses sycl in their
    implementation (like IPEX) to provide framework level code location
    information for XPTI events generated by sycl. This allows a
    framework specific instrumentation tool to capture sycl xpti events
    with code location information coming from the framework level.
    
    This commit change all sycl entry points which tries to capture code
    location in TLS to query the TLS and use the code location that was
    already set in the TLS (if any) rather then using the code location
    tried to be set.
    
    framework level software can set code location in TLS by instatiating
    the existing sycl::detail::tls_code_loc_t object.
    
    Signed-off-by: Guy Zadicario <guy.zadicario@intel.com>
    gzadicario committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8747652 View commit details
    Browse the repository at this point in the history
  2. [SYCL][XPTI] Use app captured function name for command_group events …

    …payload.
    
    When user has captured a code location in TLS before calling queue.submit,
    use the captured code location function name if exist instead the kernel name
    for the command group event payload. Kernel name is still added as metadata,
    only the payload changes.
    
    If user did not capture code location in TLS then use the kernel name for
    backward compatability. Additional version for queue.submit_impl functions
    added in order to propegate this state without breaking ABI.
    
    Signed-off-by: Guy Zadicario <guy.zadicario@intel.com>
    gzadicario committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f43a219 View commit details
    Browse the repository at this point in the history
  3. [SYCL][XPTI] Emit XPTI events for kernel nodes added to user graph.

    When graph is finalized kernels can be directly enqueued to a command
    buffer without using the scheduler, in this case XPTI events for the
    node_create/task_begin/task_end were missing.
    
    Save code location from tls when CGF is added to a graph through
    graph.add API. This captures user stored code location in TLS, if one
    was set before calling graph.add
    
    Signed-off-by: Guy Zadicario <guy.zadicario@intel.com>
    gzadicario committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8886912 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Fixed unitests build failure + added small unittest

    Added small unittest case to check that user code location
    is captured in node_create event:
    NodeCreation.QueueParallelForWithUserCodeLoc
    
    Signed-off-by: Guy Zadicario <guy.zadicario@intel.com>
    gzadicario committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ab29f52 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Added two unit tests to check notification generation for command gra…

    …ph API.
    
    Signed-off-by: Guy Zadicario <guy.zadicario@intel.com>
    gzadicario committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dd3ed98 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    2857d9d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Apply suggestions from code review

    Co-authored-by: Sergey Semenov <sergey.semenov@intel.com>
    gzadica1 and sergey-semenov authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    015a364 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b30bd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    8d202f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix ABI break

    - moved handler::MIsTopCodeLoc to handler_impl
    - updated new symbols in sycl_symbols_{linux,windows}.dump
    Guy Zadickario committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    9d0e27e View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Added comment to remove old version of saveCodeLoc at next ABI breaking

    window.
    Guy Zadickario committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    41606c8 View commit details
    Browse the repository at this point in the history