Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix device assertion bug on windows #15199

Closed
wants to merge 23 commits into from
Closed

[SYCL] Fix device assertion bug on windows #15199

wants to merge 23 commits into from

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Aug 26, 2024 •
edited
Loading

This PR fixes a device assertion bug on Windows where the assertion message and information are not printed when an assertion is triggered. Also re-enabled some tests failing because of it. See #12797.

@lbushi25 lbushi25 marked this pull request as ready for review August 26, 2024 20:07
@lbushi25 lbushi25 requested a review from a team as a code owner August 26, 2024 20:07
aelovikov-intel
aelovikov-intel approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix formatting, other than that LGTM.

@lbushi25
Copy link
Contributor Author

Please fix formatting, other than that LGTM.

Done!

@lbushi25
Copy link
Contributor Author

lbushi25 commented Aug 27, 2024 •
edited
Loading

@intel/llvm-gatekeepers
This is ready for merge. All failures are infrastructure related in the cleanup stage.
Update: I restarted the failing tasks just to have success so thats why it shows that some tasks are not complete but there are no functional failures so we can proceed with merge.

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers ping

@aelovikov-intel
Copy link
Contributor

@intel/llvm-gatekeepers ping

Please fix:

image

@lbushi25
Copy link
Contributor Author

@intel/llvm-gatekeepers ping

Please fix:

image

I haven't seen this before. Where is it from and how can I fix it?

@lbushi25
Copy link
Contributor Author

Reminder to close #12797 once this is merged.

@steffenlarsen
Copy link
Contributor

@intel/llvm-gatekeepers ping

Please fix:
image

I haven't seen this before. Where is it from and how can I fix it?

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address mentions a "noreply" github email. You may have to edit some of your github settings.

@lbushi25
Copy link
Contributor Author

Opened another clone here with hopefully proper email this time: #15232.
Closing this.

@lbushi25 lbushi25 closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbushi25 @aelovikov-intel @steffenlarsen