[SYCL] Fix uninitialized fields Coverity hits #15237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e043b8.
|
I think initializing |
uditagarwal97
approved these changes
Sep 5, 2024
|
@intel/llvm-gatekeepers This PR should be ready, thanks! |
uditagarwal97
requested changes
Sep 5, 2024
ianayl
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
approved these changes
Sep 5, 2024
|
@intel/llvm-gatekeepers Sorry for previous ping, but this PR should now actually be ready, thanks in advance! |
sommerlukas
pushed a commit
that referenced
this pull request
Sep 10, 2024
In the same vein as #15237, this PR fixes additional uninitialized values recently discovered by Coverity. Similar to the resolution discussed in #15237, I have default-initialized integer values that are defined later on to 0 instead of another more complex solution. Additionally, since I had set `MExternalSempahore` in `handler_impl` to `nullptr`, I added null checks where `MExternalSemaphore` is ultimately returned to ensure `nullptr` doesn't actually get passed into the UR. This is not necessarily necessary, but without this check Coverity would probably generate another hit because of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Coverity hits regarding uninitialized class fields in the runtime.
I'd like to bring attention to
sycl_mem_obj_t.hpphowever: There, I have initializedMSizeInBytesof theSYCLMemObjTclass to 0: This should not cause any problems (at least not more), as currently all subclasses ofSYCLMemObjTthat actually use theMSizeInByteshave it defined (buffer_impl,image_impl) when their respective constructors are called. However, this does mean programmers must remember to initializeMSizeInByteswhen usingimage_impl.To avoid this, I could rewrite some of the constructors in e.g.
image_implandSYCLMemObjT, but I'd like to not overcomplicate the problem here. So I was hoping for some other opinions: Is initializing as 0 sufficient, or should I go ahead and make the changes to the constructors anyway to be safe? Thanks in advance!