Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Skip dev-igc run if the PR has ci-no-devigc label specified #15318

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

uditagarwal97
Copy link
Contributor

Currently, if ci-no-devigc label is specified, we duplicate the E2E test run with ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest image.
This PR intends to skip the run instead of duplicating.

@sarnex
Copy link
Contributor

sarnex commented Sep 6, 2024

@uditagarwal97 LGTM, can you just post the log from a run of dev-igc before the ci-dev-igc label was set, I want to make sure that case is working but I can't find the logs :(

@uditagarwal97
Copy link
Contributor Author

@uditagarwal97 LGTM, can you just post the log from a run of dev-igc before the ci-dev-igc label was set, I want to make sure that case is working but I can't find the logs :(

That's weird. Even I can't find the logs from before. I can remove this label and re-open the PR again, if that helps.

@uditagarwal97 uditagarwal97 removed the ci-no-devigc Do NOT use IGC dev driver in CI for Matrix e2e tests label Sep 6, 2024
@uditagarwal97 uditagarwal97 reopened this Sep 6, 2024
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems working as expected, LGTM minus a typo :)

.github/workflows/sycl-linux-precommit.yml Outdated Show resolved Hide resolved
Co-authored-by: Nick Sarnie <sarnex@users.noreply.github.com>
.github/workflows/sycl-linux-precommit.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-precommit.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/sycl-linux-run-tests.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@jsji jsji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@@ -110,6 +110,8 @@ jobs:
use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }}
extra_lit_opts: --param matrix-xmx8=True --param gpu-intel-dg2=True
env: '{"LIT_FILTER":${{ needs.determine_arc_tests.outputs.arc_tests }} }'
# Run only if the PR does not have the 'ci-no-devigc' label.
skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'true' || 'false' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the ( && 'true' || 'false')?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because skip_run is of type String

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you are right. Now that I refer to GHA docs (https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#contains), contains() return true/false strings. Previously, I though contains() returns boolean values.

@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Sep 6, 2024

Test failure on Arc is unrelated. I've opened an issue for it: #15321
@intel/llvm-gatekeepers The PR is ready.

@aelovikov-intel aelovikov-intel merged commit de4851c into sycl Sep 6, 2024
18 of 29 checks passed
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/udit/arc_devigc branch September 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants