[SYCL] Fix handling of interop events for barrier with waitlist #15352
+60
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
force-pushed
the
interop_barrier_fix
branch
from
498f70f
to
809762e
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
interop_barrier_fix
branch
from
809762e
to
e05b3ed
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
interop_barrier_fix
branch
from
e05b3ed
to
2f71135
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sycl/test-e2e/Regression/barrier_waitlist_with_interop_event.cpp
Outdated
Show resolved
Hide resolved
bader
reviewed
Sep 10, 2024
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
@againull, please, add explanation of the bug in the code logic this patch fixes to the PR description. This should be useful if users will find flaws in this patch. ;) |
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 10, 2024
Yes, added to the description. |
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Command::getUrEventsBlocking is responsible for preparing a waitlist of UR events for the barrier.
This method used wrong assumption that if isEnqueued() returns false for the event then it doesn't have UR handle because it was not enqueued. So if there is an associated command we would enqueue it to get the desired UR handle, or we would just ignore this event if there is no associated command.
Problem is that sycl::event created with interoperability constructor has isEnqueued() as false (as it is not enqueued by SYCL RT) but it has UR handle provided by user.
Before this patch we just ignored such event as it doesn't have associated command and we didn't put it to the resulting list.
This patch fixes this problem by handling interop events properly in this code path.