Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Fix launch config in the max_num_work_groups e2e test #15359

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[SYCL] Fix launch config in the max_num_work_groups e2e test #15359

merged 1 commit into from
Sep 13, 2024

Conversation

GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Sep 11, 2024 •
edited
Loading

The previous global work size was exceeding the limits of INT_MAX on the intel opencl fpga emulator device and thus failing the test. This commit also cleans up the test checks validation by leaving the assertions and removing the if conditions.

@GeorgeWeb
[SYCL] Fix launch config in the max_num_work_groups e2e test
9458a8c 
The previous global work size was exceeding the limits of INT_MAX on the
intel opencl fpga emulator device and thus failing the test.
This commit also cleans up the test checks validation by
leaving the `assert`ions and removing the `if` conditions.
@GeorgeWeb GeorgeWeb requested a review from a team as a code owner September 11, 2024 15:19
@GeorgeWeb
Copy link
Contributor Author

GeorgeWeb commented Sep 11, 2024 •
edited
Loading

Fixes the Basic/launch_queries/max_num_work_groups.cpp failure in https://github.com/intel/llvm/actions/runs/10812211165/job/29993848042 reported in #15361.

@GeorgeWeb GeorgeWeb mentioned this pull request Sep 11, 2024
Closed
@GeorgeWeb GeorgeWeb mentioned this pull request Sep 11, 2024
Merged
@GeorgeWeb
Copy link
Contributor Author

Unrelated passing XFAIL: https://github.com/intel/llvm/actions/runs/10809701571/job/29985720662?pr=14333#step:22:2286

********************
Unexpectedly Passed Tests (1):
  SYCL :: OneapiDeviceSelector/no_duplicate_devices.cpp

see #15341 and #15288

@KornevNikita KornevNikita linked an issue Sep 12, 2024 that may be closed by this pull request
Post-commit failure on opencl fpga intel device #15361
Closed
@GeorgeWeb
Copy link
Contributor Author

Friendly ping @intel/llvm-reviewers-runtime / @maarquitos14 - this is supposed to fix the linked post-commit failure. Thanks!

steffenlarsen
steffenlarsen approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen steffenlarsen merged commit 5b9f0f6 into intel:sycl Sep 13, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@maarquitos14 maarquitos14 Awaiting requested review from maarquitos14 maarquitos14 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post-commit failure on opencl fpga intel device
3 participants
@GeorgeWeb @AlexeySachkov @steffenlarsen