Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Remove device_global_static.cpp test #15362

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[SYCL] Remove device_global_static.cpp test #15362

merged 1 commit into from
Sep 11, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Sep 11, 2024 •
edited
Loading

We don't think it provides value.

@sarnex sarnex marked this pull request as ready for review September 11, 2024 16:02
@sarnex sarnex requested a review from a team as a code owner September 11, 2024 16:02
@aelovikov-intel
Copy link
Contributor

In #15224 (comment):

Thanks @aelovikov-intel I'd like to keep it in if possible. I can remove at any point in time if it becomes a problem.

I'd rather remove the test :)

@sarnex
Copy link
Contributor Author

sarnex commented Sep 11, 2024

@hdelan Can I remove the test?

@hdelan
Copy link
Contributor

hdelan commented Sep 11, 2024

@hdelan Can I remove the test?

Sure go for it

@sarnex
[SYCL] Remove device_global_static.cpp test
7ec64d9 
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex changed the title [SYCL] Add llvm-strings to compile-time test deps [SYCL] Remove device_global_static.cpp test Sep 11, 2024
@sarnex sarnex requested a review from hdelan September 11, 2024 16:46
@sarnex
Copy link
Contributor Author

sarnex commented Sep 11, 2024

@aelovikov-intel Updated PR to remove test, thx

@sarnex sarnex merged commit 8d1c9f0 into intel:sycl Sep 11, 2024
9 of 13 checks passed
@sarnex
Copy link
Contributor Author

sarnex commented Sep 11, 2024

No need for CI on this, it's just removing a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-runtime

@hdelan hdelan Awaiting requested review from hdelan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarnex @aelovikov-intel @hdelan