[Driver][SYCL] Add diagnostic for bad argument with -fsycl-device-obj #15381
Conversation
When using -fsycl-device-obj, we would effectively ignore any bad arguments and default to 'llvmir'. Add a diagnostic to inform the user of the bad argument and what we are doing with our default behavior.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -69,6 +69,13 @@ | |||
| // RUN: | FileCheck -check-prefix=CHK-SYCL-TARGET %s | |||
| // CHK-SYCL-TARGET-NOT: error: SYCL target is invalid | |||
|
|
|||
| /// -fsycl-device-obj argument check | |||
| // RUN: %clang -### -fsycl-device-obj=test -fsycl %s 2>&1 \ | |||
There was a problem hiding this comment.
What is the behavior when --offload-new-driver or --no-offload-new-driver is passed?
There was a problem hiding this comment.
The behavior is the same. The use of --offload-new-driver vs --no-offload-new-driver does not change the need for the diagnostic or the behavior involved with -fsycl-device-obj.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
clang/lib/Driver/Driver.cpp
Outdated
| StringRef ArgValue(DeviceObj->getValue()); | ||
| SmallVector<StringRef, 2> DeviceObjValues = {"spirv", "llvmir"}; | ||
| auto FoundArg = | ||
| std::find(DeviceObjValues.begin(), DeviceObjValues.end(), ArgValue); |
There was a problem hiding this comment.
Since a vector is used here, llvm::find_if can be used to instead of std::find and an if to simplify this code.
There was a problem hiding this comment.
I've simplified by using llvm::find (I found find_if to be just as 'complex' as the original)
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Testing issue is a |
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers, this PR looks ready for merge - please take a look. Thanks! |
When using -fsycl-device-obj, we would effectively ignore any bad arguments and default to 'llvmir'. Add a diagnostic to inform the user of the bad argument and what we are doing with our default behavior.