Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Remove querying for unsupported platforms #15415

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL] Remove querying for unsupported platforms #15415

wants to merge 3 commits into from
+39 −114

Conversation

jchlanda
Copy link
Contributor

As discussed in #15368 this functionality should not be exposed to the users.

@jchlanda jchlanda requested review from a team as code owners September 17, 2024 12:45
@jchlanda
Copy link
Contributor Author

If a revert commit would be preferred, the change was split across two:

@jchlanda
Copy link
Contributor Author

cc: @gmlueck and @steffenlarsen

@jchlanda jchlanda mentioned this pull request Sep 17, 2024
Closed
steffenlarsen
steffenlarsen approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For other reviewers, this is an ABI break, but not a release-to-release ABI break.

@jchlanda jchlanda force-pushed the jakub/remove_unsupported_platforms branch from 820ae2b to 7573497 Compare September 18, 2024 09:38
@jchlanda
Copy link
Contributor Author

Friendly ping: @intel/unified-runtime-reviewers and @sergey-semenov

@jchlanda jchlanda force-pushed the jakub/remove_unsupported_platforms branch from 7573497 to fccc43e Compare September 23, 2024 10:39
@jchlanda
Copy link
Contributor Author

If a revert commit would be preferred, the change was split across two:

* [4443eff](https://github.com/intel/llvm/commit/4443eff6c5f613b5038ad8c4a3b3e5a6532b5c8c)

* [93ee5b9](https://github.com/intel/llvm/commit/93ee5b92cdd7502787c444181a34db0b736083b3)

Please note, this is no longer true, the codebase has moved forward and the patches would not apply correctly anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-runtime

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchlanda @steffenlarsen