Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Add lit expansion for floating point model #15476

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Sep 23, 2024

This option is set differently based on the compiler driver. With the LLVM driver we need to use -ffp-model=, while with the MSVC driver we would use /fp:

This patch introduces the expansion %fp-model- to address this.

@YuriPlyakhin
Copy link
Contributor

@ayylol ,
The change looks good, but it seems you need to rebase to latest sycl

@ayylol ayylol changed the title [SYCL][E2E] Add floating point model expansion [SYCL][E2E] Add lit expansion for floating point model Sep 23, 2024
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aelovikov-intel - Thoughts on this? Should we do this for disabling fast-math too?

@againull againull merged commit a496844 into intel:sycl Sep 24, 2024
11 checks passed
@ayylol ayylol deleted the fp-model branch September 24, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants