Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix level_zero deb file name in install_drivers.sh script #15500

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Sep 24, 2024

Level Zero started building for ubuntu 24.04 as well as 22.04, so we need to update our script to download the 22.04 one, as we use 22.04 for our docker images.

See https://github.com/oneapi-src/level-zero/releases/tag/v1.17.44

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex requested a review from a team as a code owner September 24, 2024 20:17
@sarnex sarnex requested a review from jsji September 24, 2024 20:17
@sarnex sarnex changed the title [CI] Fix level_zero deb file name [CI] Fix level_zero deb file name in install_drivers.sh script Sep 24, 2024
Copy link
Contributor

@jsji jsji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. We may want to extend relevant scripts/json files to support different OS prefixes like u22/u24 based on the OS we run the install_drivers.sh on, but that is not a must.

@sarnex
Copy link
Contributor Author

sarnex commented Sep 24, 2024

@jsji Yeah I'll take the lazy way out and say let's do that when we start testing on multiple Ubuntu versions :), thanks

@sarnex
Copy link
Contributor Author

sarnex commented Sep 25, 2024

None of the fails here should be related to this PR, and I'll watch pre/postcommit to see if they come up somehow and revert if they do.

@sarnex sarnex merged commit 68e03e8 into intel:sycl Sep 25, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants